hoplon

The :hoplon: ClojureScript Web Framework - http://hoplon.io/
2017-12-23T00:22:19.000033Z

hmmm, can we also move the experimental stuff into a new ns in 7.2+?

flyboarder 2017-12-23T00:28:44.000008Z

yes, thats better than what I had in mind which was to pull it entirely

flyboarder 2017-12-23T00:29:51.000048Z

we need a change log also πŸ˜›

2017-12-23T01:32:35.000054Z

so much to do

2017-12-23T01:47:03.000022Z

we could pull it and move to a different repo

2017-12-23T01:47:27.000026Z

i haven't personally used the experimental stuff so i don't really know much about it

flyboarder 2017-12-23T02:28:36.000095Z

it would fit inline more within hoplon/brew

flyboarder 2017-12-23T02:29:22.000049Z

really hoplon.core should be all the stable ancient code πŸ™

2017-12-23T02:50:01.000018Z

yeah, less is more i think

2017-12-23T03:22:50.000102Z

so i think the simplified but more consistent logic for these fns should just be "use managed version if parent is already managed or any child is a cell, else use native prototype fn"

2017-12-23T04:09:53.000032Z

in my branch all the overrides now look something like this

2017-12-23T04:09:57.000019Z

(defn- set-appendChild!
  [this kidfn]
  (set! (.-appendChild this)
        (fn [child]
         (this-as this
          (if (or (managed? this) (cell? child))
           (managed-append-child this child kidfn)
           (.call appendChild this child))))))

2017-12-23T07:10:33.000029Z

@flyboarder i'm finding lots of edge cases here >.< that refactor is looking more and more attractive

2017-12-23T07:26:08.000012Z

i suspect that in the refactor that insertBefore and replaceChild overrides can just be immediately deleted - they don't seem to work for cells and aren't currently used for anything internally AFAICS

flyboarder 2017-12-23T18:17:49.000055Z

Ok everyone, im going to press the big button……. any last objections!?

flyboarder 2017-12-23T19:05:12.000083Z

πŸŽ‰ It has been done [hoplon/hoplon "7.1.0"] is on Clojars! πŸŽ‰

flyboarder 2017-12-23T19:05:54.000049Z

A 🎁 from @thedavidmeister and myself πŸ™‚

1🦜1
flyboarder 2017-12-23T19:08:15.000081Z

https://github.com/hoplon/hoplon/releases/tag/7.1.0

2017-12-23T19:30:32.000047Z

this is great news, thank you and congratulations!