hmmm, can we also move the experimental stuff into a new ns in 7.2+?
yes, thats better than what I had in mind which was to pull it entirely
we need a change log also π
so much to do
we could pull it and move to a different repo
i haven't personally used the experimental stuff so i don't really know much about it
it would fit inline more within hoplon/brew
really hoplon.core should be all the stable ancient code π
yeah, less is more i think
so i think the simplified but more consistent logic for these fns should just be "use managed version if parent is already managed or any child is a cell, else use native prototype fn"
in my branch all the overrides now look something like this
(defn- set-appendChild!
[this kidfn]
(set! (.-appendChild this)
(fn [child]
(this-as this
(if (or (managed? this) (cell? child))
(managed-append-child this child kidfn)
(.call appendChild this child))))))
@flyboarder i'm finding lots of edge cases here >.< that refactor is looking more and more attractive
i suspect that in the refactor that insertBefore
and replaceChild
overrides can just be immediately deleted - they don't seem to work for cells and aren't currently used for anything internally AFAICS
Ok everyone, im going to press the big buttonβ¦β¦. any last objections!?
π It has been done [hoplon/hoplon "7.1.0"]
is on Clojars! π
A π from @thedavidmeister and myself π
this is great news, thank you and congratulations!