@flyboarder thanks for the quick merge!
is there any way we could push a release through? my plan is to submit a PR to hoplon/google-maps upgrading its hoplon/google-loader dependency to a new version that includes my patch, and then use the upgraded hoplon/google-maps, which will allow me to tighten the CSP on the hoplon app i'm securing
i tried to fork hoplon/google-maps and hoplon/google-loader, but ran into all kinds of crazy problems involving hoplon and the classpath. i'm guessing it's because i didn't build hoplon/google-loader correctly, like maybe it requires a specific version of boot and invocation of the
hoplon task in the build pipeline? (the source file is .cljs.hl)
@raywillig maybe you have some context?
this is the error i ran into when i tried to use my forks:
@dave we should fix that, libraries shouldnt use the .cljs.hl files
i also tried pulling the source for google-loader into the google-maps repo, and translating the .cljs.hl into .cljs. that built and ran with no errors, but then my app completely lost its mind and threw a bunch of JS console errors like
core.cljs:717 Uncaught TypeError: elem.addEventListener is not a function
maybe because i'm using a newer version of hoplon than the one that was around when google-loader was written
Uncaught Error: No protocol method IDeref.-deref defined for type object: [object Event]
@flyboarder that makes perfect sense to me. i'm happy to submit a PR for that actually
i've already done the translation
Yep, let’s do it!
it was a no-op
google-loader (2 tasks ready) → git rebase -i origin/master Successfully rebased and updated refs/heads/cljs-hl-to-cljs. google-loader (2 tasks ready) → gs On branch cljs-hl-to-cljs Your branch is up-to-date with 'daveyarwood/cljs-hl-to-cljs'. nothing to commit, working directory clean google-loader (2 tasks ready) → gpf Everything up-to-date
i need to pull origin master
there we go, there is a conflict i can resolve
argh, hang on
ok, NOW it's fixed 🙂