Clojurians Log v2

Hi guys. Has anyone used Sente with Immutant? I’m having trouble conceptualizing how state is maintained across multiple connections.

Greetings Immutants! I just upgraded one of our projects from 2.0.2 to 2.1.0 and the system is throwing the following error:

The system throws the error when I require any Immutant library

The offending code: https://github.com/immutant/immutant/blob/master/core/src/immutant/internal/util.clj#L121

It’s a type hint in a file that says “No longer used”.

My other projects don’t fail because they use Datomic, which brings in org.slf4j.Logger.

BTW, we use timbre for logging.

Thoughts?

@statonjr: howdy!

do you explicitly exclude slf4j?

No

and I'm surprised the behavior changed with 2.1.0, that hint has been there since 2.0.0

Agreed. Sure surprised me!

where do you see that it's no longer used?

can you try lein clean?

@seantempesta: what sort of state are you referring to?

@tcrawley: On the top of the file in GitHub. May not be referring to that file

I tried lein clean to no avail

When I run lein test or lein run with 2.0.2, I get the standard slf4j output:

ah, "no longer used" was the latest commit, in ref to a removed macro

can you share lein deps :tree with 2.0.2 and 2.1.0? maybe we changed a transitive dep somewhere

Yeah. One sec...

it looks like wunderboss-core used to bring it in, let me see what we changed there

I see it now

the culprit: https://github.com/projectodd/wunderboss/commit/626b39b743079a9e25d2d7ad44a319a9dd150a7b

I suspect

it seems like logback should bring in slf4j, or at least that's implied by the commit

@jcrossley3: are you here?

I'm going to see what happens with a bare-bones app

In my project.clj: [org.immutant/web "2.0.2" :exclusions [ch.qos.logback/logback-classic]]

ah

so you may just have to explicitly depend on slf4j then

And it works if I remove the exclusion.

progress!

I just need to remember why we excluded logback in the first place! Probably due to that reflection warning.

Thanks for the help!

my pleasure!

glad you guys figured that out without me :simple_smile: