@bostonaholic: looks like the issue on my end is the jersey sse client we use when testing - it doesn't actually close the socket on close, so the server can't detect a close when send! is called
the event that should trigger the :on-close
just gets swallowed by the client
if I test with a browser, and close the tab mid sse stream, :on-close
does get called
what are you using to test with?
browser
but I didn’t do an exhaustive test to check if on-close wasn’t being called. It didn’t seem like it, at first.
I can throw together a simple test app if you are willing to try it
just to demonstrate what I'm seeing
that’d be super helpful
k, give me a few minutes
@bostonaholic give https://github.com/tobias/immutant-631 a try and see how it behaves for you
tcrawley: works for me. Thanks for putting this together.
Good deal, and my pleasure!
thanks @tcrawley. I’ll try to take a look at it later to today and get back with you.
coolio, no rush