GitHub: Discord (official chat):
valtteri 2018-02-28T07:38:10.000267Z

I fiddled with a bit and managed to get the overlay display logic around inf-clojure-eval-... functions quite easily but I hit the wall when I realized that i.e. inf-clojure-eval-last-sexp doesn’t return the output from the clojure subprocess. What would be the way to get my hands on the output value to display it in the overlay?

richiardiandrea 2018-02-28T15:31:56.000247Z

@valtteri can you write a PR against it? I would like to see it and I can help there 😸

richiardiandrea 2018-02-28T15:39:06.000258Z

Comint magic is necessary there

valtteri 2018-02-28T15:41:02.000531Z

@richiardiandrea basically what I did was: - copy-paste eros.el under my ~/.emacs - find&replace eros -> test123 - changed references from eval-last-sexp -> inf-clojure-eval-last-sexp - changed references from eval-last-defun -> inf-clojure-eval-last-defun --> got overlays visible --> got stuck I have no clue whether this is a right direction, but if you think it helps, I can open a PR. I have time tomorrow to clean up the code and figure out where to stick it in inf-clojure.el

valtteri 2018-02-28T15:45:11.000185Z

(disclaimer: I have now ~1day of elisp experience and therefore I’m not very confident with my stuff. 😄 But it is kinda fun to fiddle with it!)

richiardiandrea 2018-02-28T15:46:14.000603Z

I think we can make it work, I just want to spare you the comint will see it in the PR 😃 oh no worries I am far far from an expert but Bozhidar will for sure check our work :simple_smile:

valtteri 2018-02-28T15:46:53.000307Z

Ok, cool! I’ll open the PR tomorrow and you may spell your magic on it. 😉

valtteri 2018-02-28T16:28:48.000308Z

It didn’t take so long so I created the PR already.. 🙂 As you might have noticed @richiardiandrea

richiardiandrea 2018-02-28T16:29:08.000029Z


valtteri 2018-02-28T16:31:34.000514Z

Let me know if you have any comments on the PR description or contents! I opened it quite quickly and didn’t check the conventions/code-of-conduct very carefully.. I’m calling it a day now, but I’ll be back tomorrow. 🙂

richiardiandrea 2018-02-28T16:45:21.000762Z

Thanks a lot! Don't worry that's awesome and good :)))