I fiddled with https://github.com/xiongtx/eros a bit and managed to get the overlay display logic around inf-clojure-eval-...
functions quite easily but I hit the wall when I realized that i.e. inf-clojure-eval-last-sexp
doesn’t return the output from the clojure subprocess. What would be the way to get my hands on the output value to display it in the overlay?
@valtteri can you write a PR against it? I would like to see it and I can help there 😸
Comint magic is necessary there
@richiardiandrea basically what I did was:
- copy-paste eros.el under my ~/.emacs
- find&replace eros
-> test123
- changed references from eval-last-sexp
-> inf-clojure-eval-last-sexp
- changed references from eval-last-defun
-> inf-clojure-eval-last-defun
--> got overlays visible
--> got stuck
I have no clue whether this is a right direction, but if you think it helps, I can open a PR. I have time tomorrow to clean up the code and figure out where to stick it in inf-clojure.el
(disclaimer: I have now ~1day of elisp experience and therefore I’m not very confident with my stuff. 😄 But it is kinda fun to fiddle with it!)
I think we can make it work, I just want to spare you the comint part...you will see it in the PR 😃 oh no worries I am far far from an expert but Bozhidar will for sure check our work :simple_smile:
Ok, cool! I’ll open the PR tomorrow and you may spell your magic on it. 😉
It didn’t take so long so I created the PR already.. 🙂 As you might have noticed @richiardiandrea
Awesome!
Let me know if you have any comments on the PR description or contents! I opened it quite quickly and didn’t check the conventions/code-of-conduct very carefully.. I’m calling it a day now, but I’ll be back tomorrow. 🙂
Thanks a lot! Don't worry that's awesome and good :)))