@audiolabs If I recall correctly otherwise you'd get several ghost prompts from comint-mode
.
(each newline would result in some blank prompt being displayed)
@bozhidar if I remove that code (`inf-clojure--make-single-line`), I do not get that behaviour. I haven't tried anything but clj/cljs. Notably, clj works totally fine with inferior-lisp as-is without this code. So I'm a bit confused by its existence.
I thought perhaps it was a workaround for joker, lumo or planck. I have not tested (nor do I care to)
@audiolabs if you create an issue and assign it to dpsutton i can dig a bit through these
will do
thanks!
@dpsutton unable to assign, but issue is above ^
> Notably, clj works totally fine with inferior-lisp as-is without this code. So I'm a bit confused by its existence. (edited)
It's possible that something has changed, but I'm pretty sure this didn't work properly in the past.
This was the original problem this was supposed to address https://github.com/clojure-emacs/inf-clojure/issues/7
It does not appear to be an issue with latest clojure, macOS 11.1 and emacs 27.1, at least.
I did quickly check in emacs 26.3 and macOS catalina, with no issues noted. No clojure <1.10 tested.
I suspect maybe there was a change to a comint-input-filter somewhere between now and 2015?
Perhaps comint
handles such cases differently today. I'd be happy to remove this if it's no longer needed.
well, I have about 90 hours of using inf-clojure with that code removed under the conditions listed above 😉
I don't know how well that may translate to other environments or versions
When in doubt - delete first and check if someone complains later. 😄 This has historically worked pretty well for me.
Hey just answered to the above if - I like the ☝️ take - my patch was working for everything I tried except lumo