inf-clojure

GitHub: https://github.com/clojure-emacs/inf-clojure Discord (official chat): https://discord.gg/nFPpynQPME
bozhidar 2021-02-13T16:49:49.003500Z

@audiolabs If I recall correctly otherwise you'd get several ghost prompts from comint-mode.

bozhidar 2021-02-13T16:50:14.003800Z

(each newline would result in some blank prompt being displayed)

2021-02-13T16:57:28.005400Z

@bozhidar if I remove that code (`inf-clojure--make-single-line`), I do not get that behaviour. I haven't tried anything but clj/cljs. Notably, clj works totally fine with inferior-lisp as-is without this code. So I'm a bit confused by its existence.

2021-02-13T16:58:03.006Z

I thought perhaps it was a workaround for joker, lumo or planck. I have not tested (nor do I care to)

dpsutton 2021-02-13T17:00:23.006600Z

@audiolabs if you create an issue and assign it to dpsutton i can dig a bit through these

2021-02-13T17:01:04.007200Z

will do

dpsutton 2021-02-13T17:01:08.007400Z

thanks!

2021-02-13T17:11:43.007800Z

@dpsutton unable to assign, but issue is above ^

bozhidar 2021-02-13T17:18:08.008300Z

> Notably, clj works totally fine with inferior-lisp as-is without this code. So I'm a bit confused by its existence. (edited)

bozhidar 2021-02-13T17:18:39.008900Z

It's possible that something has changed, but I'm pretty sure this didn't work properly in the past.

bozhidar 2021-02-13T17:23:18.009200Z

This was the original problem this was supposed to address https://github.com/clojure-emacs/inf-clojure/issues/7

2021-02-13T18:07:57.009600Z

It does not appear to be an issue with latest clojure, macOS 11.1 and emacs 27.1, at least.

2021-02-13T18:08:47.010400Z

I did quickly check in emacs 26.3 and macOS catalina, with no issues noted. No clojure <1.10 tested.

2021-02-13T18:09:33.011400Z

I suspect maybe there was a change to a comint-input-filter somewhere between now and 2015?

bozhidar 2021-02-13T18:09:36.011500Z

Perhaps comint handles such cases differently today. I'd be happy to remove this if it's no longer needed.

2021-02-13T18:11:27.012400Z

well, I have about 90 hours of using inf-clojure with that code removed under the conditions listed above 😉

2021-02-13T18:11:55.012800Z

I don't know how well that may translate to other environments or versions

bozhidar 2021-02-13T18:51:09.013400Z

When in doubt - delete first and check if someone complains later. 😄 This has historically worked pretty well for me.

2✔️1😂
richiardiandrea 2021-02-13T20:38:24.015300Z

Hey just answered to the above if - I like the ☝️ take - my patch was working for everything I tried except lumo