jackdaw

https://github.com/FundingCircle/jackdaw
xi 2019-07-25T06:44:31.053500Z

I mean that the key serde I pass through still doesn't seem to take effect 😞

xi 2019-07-25T06:45:06.054200Z

I would normally write a test but I was a little put off by not being able to see any others around custom serdes

xi 2019-07-25T07:32:35.054500Z

Having a go now, laziness overcome by expediency

xi 2019-07-25T09:52:51.055300Z

My autoformatter fixed some minor issues in the test file, I can remove those if it's an issue

xi 2019-07-25T09:53:27.055900Z

I actually don't understand the result for L954, but the serdes work so ^^

xi 2019-07-25T10:23:39.056600Z

Got my local bug 🙂 it had the same failure condition as the Jackdaw bug I fixed, which is why I thought the PR was broken initially

2019-07-25T10:26:21.056700Z

Yeah if you don't mind that would be appreciated.

xi 2019-07-25T10:26:54.057300Z

Can I supply a second PR to fix them?

2019-07-25T10:27:41.058100Z

Yep

👍 1
2019-07-25T10:28:56.059300Z

Cool. I thought the PR looked good. Great to hear it's working for you now. I'll get a few more 👀 on it today.

xi 2019-07-25T10:30:59.059500Z

Thanks