Clojurians Log v2
java
any java people available to help me get https://gitlab.ow2.org/asm/asm up and running so i can run some tests and make a patch? it's gradle based and I have no idea where to start 🙂
@dpsutton Is this to address the bug I reported?
yup!
but i figured out gradlew so I can run tests now
I have 4 years in C# and none in java proper
you said we call byte to short as well, right?
in addition to the byte -> int
short to int fails
ah. is that a no-op? i have no idea about these types in java 🙂
Yeah, promotion is "free". The .cast() call deals with all the non-int from cases first and then all the to cases -- and throws an exception on no-ops now (where from != to).
(from memory -- I'm watching TV and not looking at the source)
yeah. I think maybe just getting rid of the exception is the way to go?
FWIW, when I tested Clojure and my patch, I ran all the tests first (there was a failure, unrelated), then I added my fix and made sure it didn't break anything, then I added my tests and made sure those past, then I removed my fix and made sure the extra tests failed, then put my fix back (and re-tested).
casts from long/double/float (and maybe others) to int all work -- those are handled just fine by the ASM code.
It's only short->int and byte->int as far as I can tell.
Good stuff @dpsutton!
Alex indicated there would be no fix applied to Clojure for a few weeks due to other commitments so I may well build a variant of Alpha 5 with my fix and run a bunch of tests against the World Singles code base...
they should just revert the asm update until its resolved i guess
but i have no idea what the implications of that dependency is, how old, etc
and wow. i forgot what its like to code in C#/java. I don't miss it lol
Reverting the ASM update doesn't seem like a solution to me.
Either apply my patch, or update the local re-vendored copy of GeneratorAdapter.