juxt

2019-01-22T09:49:15.046700Z

is this a good place to ask a question about Aero?

dominicm 2019-01-22T11:11:01.047100Z

Yeah!

2019-01-22T11:25:29.050700Z

Crossposting because I didn't find a response about edge in #yada so I I thought I'd ask here: I've watched the edge demo and read the docs and I'm looking at the code. I feel that edge is aimed towards a single repo for all your services. This is because none of these libs are published and the references to edge libs are all relative. e.g. ../lib.app.dev Am I missing something?

2019-01-22T12:03:56.051300Z

@malcolmsparks I saw you merged already: https://github.com/juxt/aero/pull/69 it was still WIP because I didn't get it work yet

2019-01-22T12:04:09.051800Z

but well I didn't break it I guess since it was already not working anyway

2019-01-22T12:04:52.052900Z

I'll do another PR when I get it work, in theory you might also want to set in the github settings for the repo to check for the two test-clj and test-cljs jobs, because atm they are not really enforced to pass (once the tests are all passing at least)

2019-01-22T12:06:22.054200Z

I would have also squashed my commits if I knew it was going to be merged, I'll just mark it as WIP more clearly next time sorry about that

malcolmsparks 2019-01-22T12:08:32.054600Z

ok - thanks for the info, I'll back out the PR

2019-01-22T12:27:37.055Z

ok @malcolmsparks https://github.com/juxt/aero/pull/70 now everything works

2019-01-22T12:27:47.055700Z

and it's a more proper PR with just one commit

👍 1
dominicm 2019-01-22T12:34:17.056200Z

Looks good

2019-01-22T13:45:43.056600Z

only think I haven't done is to add some caching

2019-01-22T13:45:55.056900Z

but it's so fast anyway so it doesn't matter so much

dominicm 2019-01-22T13:47:08.057500Z

I think this is great