Clojurians Log v2

ERROR: Error in reporter probably means it's a Kaocha bug. Congratulations! 🙂

hmmm having a better look at your stack trace maybe it's not a Kaocha bug, I think this line is clojure.test is involved

(println "  actual:" (pr-str (:actual m)))))

asking questions here is fine btw, it's what everyone does 🙂

Thanks Arne!

If it’s a bug in clojure.test then why don’t I see something similar when I run the test var directly? Ah, maybe it’s something in the clojure.test “find-and-run-some-tests” facility? I’ll try that…

Ah, I’ve already fixed the bug in my code so I need to backtrack to find the commit that caused the problem… 😅

The Clojure test reporting is definitely strange because you're only getting the "expected" part. There should be a line after that starting with "Actual:". If that's not there then my guess is clojure.test is swallowing the exception

Ah… ok… so… do I report a bug somewhere?

I’m a little fuzzy on how to report bugs in Clojure right now… I know feature requests go to the “ask” site. Maybe I should post the problem to #testing ?

See if you can make a minimal reproduction. If my guess is correct then creating a lazy-seq that throws and using that in the first position of (is (=)) should be enough. I can try it out tomorrow as well.

Actually it's perhaps a little more involved, you'd have to make sure the equality check doesn't throw, but the printing does...

It's a pretty niche edge case :)

😓

I'll test it out when I get a chance. I may be widely off with my speculation but it's the only theory I have that would explain what you're seeing

ok, thank you!

Not at a computer now so I can't try it out but it would look something like this (is (= [0 (lazy-seq (throw (Exception.)))] [1]))

The equality check should just return false because it short circuits after comparing the first element, but printing would throw

user> (deftest foo-test (is (= [0 (lazy-seq (throw (java.lang.IllegalArgumentException.)))] [1])))
#'user/foo-test
user> (foo-test)

FAIL in (foo-test) (NO_SOURCE_FILE:187)
expected: (= [0 (lazy-seq (throw (java.lang.IllegalArgumentException.)))] [1])

ERROR in (foo-test) (NO_SOURCE_FILE:187)
expected: (= [0 (lazy-seq (throw (java.lang.IllegalArgumentException.)))] [1])
  actual: java.lang.IllegalArgumentException: null
 at user$fn__15257$fn__15258.invoke (NO_SOURCE_FILE:187)
    clojure.lang.LazySeq.sval (LazySeq.java:42)
    clojure.lang.LazySeq.seq (LazySeq.java:51)

Is that snippet you shared at the beginning really the full output you're getting from (dad.db.export-test/split-record)?

I believe it was; I’ll have to back-track and try to reproduce it

This is the branch I’m working on right now 😅

(every single commit message is just WIP++ 😬)

Wonder if this is more tractable in Clojure than Ruby: https://engineering.shopify.com/blogs/engineering/spark-joy-by-running-fewer-tests ... be a neat add-on for Kaocha.

TL;DR: they’re making up a call graph for every test, and when your code changes any call in the graph, that gets used to figure out which tests should run.

(The full suite happens before deploy; this happens to speed up PR merging).