Clojurians Log v2

I’m a bit confused. Is spec instrumentation supposed to be on by default? Im not seeing that happening and adding a hook pre-test to enable it causes internal kaocha spec errors on id & type

Have to admit that Im still trying to figure out things

have you seen the orchestra plugin?

I am also interested though in what you're seeing, what does your hook look like and what's the error you're getting?

;; tests.edn
#kaocha/v1
{:tests [{:id :all
          :type :kaocha.type/clojure.test
          :test-paths ["test"]
          :source-paths ["src" "specs" "dev/src" "dev/resources" "test/resources"]
          :kaocha.hooks/pre-test [dev.check-specs-hook]
          :kaocha.hooks/post-test [dev.uncheck-specs-hook]
          }
         ]
 :plugins [:kaocha.plugin/filter
           :kaocha.plugin/capture-output
           :kaocha.plugin/profiling
           :kaocha.plugin/hooks]
 }

;; Hook
(defn check-specs-hook [suite test-plan]
  (check-specs!) ;; fn that only does (stest/instrument)
  suite)

https://gist.github.com/kardan/03a9e70cf64f267cec89773c126f255a

“should contain keys: :kaocha.testable/id, :kaocha.testable/type”

Might very well be me doing something silly, I feel a bit confused

no stack trace I guess? it's validating the test plan as if it's a testable, which it isn't, so that there's no id/type is fine, probably some function has too stringent an fdef defined

No, sorry no stacktrace

in any case the orchestra plugin should do what you want, or if you want to instrument with spec instead of orchestra then do what that one does, i.e. use post-load hook for instrumenting, and post-run for unstrumenting

Thanks