Clojurians Log v2

Is there a reason for keechma-router to have public/index.html in the build? It's colliding with figwheel and causing problems.

@mihaelkonjevic, it looks like @bhauman went ahead and created an issue for this: https://github.com/keechma/router/issues/1

@ghopper New version (0.1.2) is released which addresses this issue

Thanks, @mihaelkonjevic!

@mihaelkonjevic, will that new version be in keechma, or should I just add a dependency for the 0.1.2 router in addition?

Add explicit dependency for now. I'll make a new keechma release in a day or two (I have some other things I've planned for this release)

:thumbsup: Thanks for the quick turnaround. 🙂 Now lein-doo has a public/index.html... 😕

@mihaelkonjevic lein-doo can be a dev dep, right? https://github.com/keechma/keechma/blob/master/project.clj#L14

:scope "test", I guess

Yeah, it can. I think you can add it as an exclusion. BTW which lein template are you using? I don't have any of these problems in keechma template so I'd like to check what's going on (to make sure this is not happening)

Oh, I'm using deps.edn. I'll do an exclusion; thanks for the idea.

Ah, ok I'll check how it works with deps.edn then

Hmm, deps.edn doesn't seem to accept my :exclusions. 😕

@ghopper can you send me your deps.edn file?

@mihaelkonjevic I've got a lot of misc aliases and whatnot in my deps.edn. This reproduces it though:

{:deps {org.clojure/clojurescript {:mvn/version "1.10.339"}
        keechma/keechma {:mvn/version "0.3.12" :exclusions [lein-doo]}
        keechma/router {:mvn/version "0.1.2"}}}

Try adding it as an exclusion to the router too

I'm using lein-doo in all keechma related projects. I'll have to go and cleanup all of the project.clj files

(from clj -Stree)

keechma/keechma 0.3.12
  com.cognitect/transit-cljs 0.8.239
    com.cognitect/transit-js 0.8.846
  cljsjs/react-with-addons 15.6.1-0
  lein-doo/lein-doo 0.1.7
    doo/doo 0.1.7
      karma-reporter/karma-reporter 0.1.0
  syntest/syntest 0.1.0
    cljsjs/jquery 3.2.1-0
    funcool/promesa 1.9.0
  org.clojars.mihaelkonjevic/cljs-react-test 0.1.5
    camel-snake-kebab/camel-snake-kebab 0.4.0
  prismatic/dommy 1.1.0
  com.stuartsierra/dependency 0.2.0

I added it to the router as well.

@ghopper Try adding it as lein-doo/lein-doo

It works for me. This is the output:

clj -Stree
org.clojure/clojure 1.9.0
  org.clojure/core.specs.alpha 0.1.24
  org.clojure/spec.alpha 0.1.143
keechma/router 0.1.2
  secretary/secretary 1.2.3
    com.cemerick/clojurescript.test 0.2.3-SNAPSHOT
org.clojure/clojurescript 1.10.339
  org.clojure/data.json 0.2.6
  org.clojure/google-closure-library 0.0-20170809-b9c14c6b
    org.clojure/google-closure-library-third-party 0.0-20170809-b9c14c6b
  org.mozilla/rhino 1.7R5
  com.cognitect/transit-clj 0.8.309
    com.cognitect/transit-java 0.8.332
      commons-codec/commons-codec 1.10
      com.fasterxml.jackson.core/jackson-core 2.8.7
      org.msgpack/msgpack 0.6.12
        com.googlecode.json-simple/json-simple 1.1.1
        org.javassist/javassist 3.18.1-GA
  org.clojure/tools.reader 1.3.0-alpha3
  com.google.javascript/closure-compiler-unshaded v20180610
    com.google.errorprone/error_prone_annotations 2.0.18
    com.google.jsinterop/jsinterop-annotations 1.0.0
    com.google.javascript/closure-compiler-externs v20180610
    com.google.guava/guava 22.0
      org.codehaus.mojo/animal-sniffer-annotations 1.14
      com.google.j2objc/j2objc-annotations 1.1
    args4j/args4j 2.33
    com.google.protobuf/protobuf-java 3.0.2
    com.google.code.findbugs/jsr305 3.0.1
    com.google.code.gson/gson 2.7
keechma/keechma 0.3.12
  cljsjs/react-dom 15.6.1-0
  com.cognitect/transit-cljs 0.8.239
    com.cognitect/transit-js 0.8.846
  cljsjs/react-with-addons 15.6.1-0
  reagent/reagent 0.7.0
    cljsjs/create-react-class 15.5.3-0
  cljsjs/react-dom-server 15.6.1-0
  syntest/syntest 0.1.0
    cljsjs/jquery 3.2.1-0
    funcool/promesa 1.9.0
    org.clojure/core.async 0.3.443
      org.clojure/tools.analyzer.jvm 0.7.0
        org.clojure/tools.analyzer 0.6.9
        org.clojure/core.memoize 0.5.9
          org.clojure/core.cache 0.6.5
            org.clojure/data.priority-map 0.0.7
        org.ow2.asm/asm-all 4.2
  org.clojars.mihaelkonjevic/cljs-react-test 0.1.5
    camel-snake-kebab/camel-snake-kebab 0.4.0
  prismatic/dommy 1.1.0
  com.stuartsierra/dependency 0.2.0

I tried that, but it wasn't on both. I'll try that.

@mihaelkonjevic, it works, but I still get the the index.html from <http://clojure.java.io/resource|clojure.java.io/resource>. 😕

Clojure 1.9.0
user=&gt; (require '<http://clojure.java.io|clojure.java.io>)
nil
user=&gt; (<http://clojure.java.io/resource|clojure.java.io/resource> "public/index.html")
#object[java.net.URL 0x6b4a2887 "jar:file:/data/prs/m2/repository/keechma/keechma/0.3.12/keechma-0.3.12.jar!/public/index.html"]
user=&gt;

@ghopper I’ve pushed keechma 0.3.13 . It includes the latest router and it doesn’t have the resources folder in the keechma project

@mihaelkonjevic, Thanks! 🙂

Heh, now I've got a syntest public/index.html. 😛

You can also exclude syntest, it's for test purposes. What is the command you're using for running the app? I'll try to clean everything up tomorrow

Yeah, I'll need to see if that's the last step needed later. I've got a flight to catch.

Thanks for taking care of this so quick.

No problem, feel free to ping me if you have any questions

@mihaelkonjevic keechma/keechma {:mvn/version "0.3.13" :exclusions [lein-doo/lein-doo syntest/syntest]} works like a charm. 🙂 Thanks!