klipse

Yehonathan Sharvit 2017-02-18T16:15:02.001008Z

Yes

moxaj 2017-02-18T17:03:29.001013Z

if I remove (src-cb {:lang :clj :source ""}), it works, both in the repl, and with external libs

moxaj 2017-02-18T17:07:04.001014Z

was that piece of code accidentally left there? ^^

Yehonathan Sharvit 2017-02-18T17:48:49.001015Z

This is a huge mistake!

Yehonathan Sharvit 2017-02-18T17:48:59.001016Z

Probably a wrong merge

Yehonathan Sharvit 2017-02-18T17:49:08.001017Z

How did you find it?

moxaj 2017-02-18T17:51:31.001018Z

I suspected the problem had something to do with load-ns

moxaj 2017-02-18T17:52:05.001019Z

and eventually, I just stumbled upon that line

Yehonathan Sharvit 2017-02-18T17:52:25.001020Z

such a stupid mistake 😞

moxaj 2017-02-18T17:52:31.001021Z

😕

moxaj 2017-02-18T17:53:02.001022Z

happens

Yehonathan Sharvit 2017-02-18T17:53:09.001023Z

can u send me a pr and I’ll deploy it soon

Yehonathan Sharvit 2017-02-18T17:53:11.001024Z

?

moxaj 2017-02-18T17:53:14.001025Z

sure

moxaj 2017-02-18T18:03:16.001026Z

could you approve my previous PR? it's been merged, but not approved

moxaj 2017-02-18T18:04:48.001027Z

github still believes i'm 3 commits ahead

Yehonathan Sharvit 2017-02-18T18:05:08.001028Z

I cannot find the button for approving the PR

moxaj 2017-02-18T18:09:36.001029Z

it seems you've approved one of the commits. anyway, I've submitted the PR, it's only a slight noise

Yehonathan Sharvit 2017-02-18T18:11:35.001030Z

In your PR I see also the contents of the previous PR

moxaj 2017-02-18T18:13:19.001032Z

I suspect that's because of this approval addon? the previous 2 commits are already merged into master

moxaj 2017-02-18T18:14:59.001033Z

oh wait, I think I know

moxaj 2017-02-18T18:16:15.001034Z

I don't 😕

moxaj 2017-02-18T18:29:11.001035Z

meh, i'll just create a fresh fork

moxaj 2017-02-18T18:33:21.001036Z

@viebel done

Yehonathan Sharvit 2017-02-18T18:36:48.001037Z

merged

moxaj 2017-02-18T18:37:36.001038Z

nice, i'll test my lib right away when deployed

Yehonathan Sharvit 2017-02-18T18:47:29.001039Z

For some reason in your code there was a hidden character at the beginning of io.cljs

Yehonathan Sharvit 2017-02-18T18:47:44.001041Z

-&lt;U+FEFF&gt;(ns <http://klipse.lang.clojure.io|klipse.lang.clojure.io>
+(ns <http://klipse.lang.clojure.io|klipse.lang.clojure.io>

moxaj 2017-02-18T18:48:35.001042Z

hm, thats a BOM, sorry about that

moxaj 2017-02-18T18:48:46.001043Z

dunno how it got there

Yehonathan Sharvit 2017-02-18T18:48:57.001044Z

NP

Yehonathan Sharvit 2017-02-18T18:49:26.001045Z

I’m adding your klipse-test repo to my tests

Yehonathan Sharvit 2017-02-18T19:04:42.001046Z

Deployed @moxaj 👏

👍 1
Yehonathan Sharvit 2017-02-18T19:04:58.001048Z

Please make sure you get klipse version 6.7.0

Yehonathan Sharvit 2017-02-18T20:21:53.001050Z

Thanks to @moxaj, now klipse implicitly loads macro namespaces

Yehonathan Sharvit 2017-02-18T20:22:18.001051Z

@arnaud_bos it should make your life easier with core.matrix