lein-figwheel

bhauman 2016-06-15T13:39:55.000083Z

You may need to upgrade your ClojureScript version.

👍 1
verma 2016-06-15T20:36:59.000085Z

I just upgraded to 0.5.4-3 and it seems like :websocket-host has no effect 😕 .. the client always tries to connect to localhost:3449

verma 2016-06-15T20:37:35.000088Z

^ edited version number and port

verma 2016-06-15T20:38:23.000089Z

anyone else seeing this or am I screwing this up? .. my lein figwheel is running inside a docker instance and I get the index.html served correctly through localhost

verma 2016-06-15T20:38:42.000090Z

;; If no code is to be run, set :figwheel true for continued automagical reloading
                :figwheel {:on-jsload "teamchat.core/on-js-reload"
                           :websocket-host "localhost"}

verma 2016-06-15T20:39:22.000091Z

^ this is what I have in [:cljsbuilds :builds 0 :figwheel]

verma 2016-06-15T20:44:18.000092Z

creating a test project to test it out

verma 2016-06-15T20:48:16.000093Z

ok, confirmed on a new project

verma 2016-06-15T21:02:03.000094Z

logged an issue here: https://github.com/bhauman/lein-figwheel/issues/431

verma 2016-06-15T21:02:08.000096Z

will continue looking at it

bhauman 2016-06-15T21:05:40.000097Z

:websocket-host only manipulates the host name not the port

bhauman 2016-06-15T21:06:04.000098Z

@verma ^

verma 2016-06-15T21:06:11.000099Z

oh

bhauman 2016-06-15T21:06:38.000100Z

This did change

bhauman 2016-06-15T21:06:45.000101Z

It was a bug

verma 2016-06-15T21:06:48.000102Z

oh ok, I was wondering

verma 2016-06-15T21:07:22.000103Z

alright, so the figwheel socket will always connect over 3449?

verma 2016-06-15T21:08:11.000104Z

my use case is that my figwheel runs behind a proxy since I have to proxy multiple APIs my cljs app calls into

verma 2016-06-15T21:08:53.000105Z

so my web listens on port 80 and everything is proxied under that ... /api/1 /api/2

bhauman 2016-06-15T21:09:45.000106Z

Even the figwheel websocket?

verma 2016-06-15T21:09:55.000107Z

for now I have opened up port 3449 on my proxy (nginx) and routed traffic through to figwheel-host:3449/figwheel-ws

verma 2016-06-15T21:09:57.000108Z

yes

verma 2016-06-15T21:10:20.000109Z

since websocket-host was overriding the port as well, so it felt natural

bhauman 2016-06-15T21:10:51.000110Z

You can use :websocket-url

bhauman 2016-06-15T21:11:19.000111Z

Look at the new docs on it in the readme.

verma 2016-06-15T21:11:21.000112Z

yeah, I noticed a change around that, so that's the recommended approach? (I will update the issue)

verma 2016-06-15T21:11:28.000113Z

ok

verma 2016-06-15T21:12:14.000114Z

:thumbsup: for websocket-url though, since I can now do wss for one of my projects 🙂

verma 2016-06-15T21:16:38.000115Z

ok, issue updated and closed, thanks @bhauman

verma 2016-06-15T21:18:42.000116Z

works as expected :thumbsup:

2016-06-15T23:03:37.000117Z

@bhauman: upgrading to the latest clojurescript fixed the warnings right up, thanks!