Clojurians Log v2

@jonas: this might be a bug.

yeah, if it’s not on purpose I guess it’s a bug. I guess my second snippet would be a solution?

Should I open a PR? I guess it might break some code if someone is relying on request being available?

yes, that would be nice.

and please provide a test case and an entry to CHANGES.markdown which would make my life easier :simple_smile:

ok. Not quite sure how to test this? Check that request is not defined inside defresource?

check that using „request“ as a parameter name to defresource works.

(liberator.core/defresource xxx [request] :handle-ok (str request))
((xxx "test") {:request-method :get})
;; => {:status 200, :headers {"Content-Type" "text/plain;charset=UTF-8"}, :body "{:request-method :get}“}

this should maybe return „test“ instead.

ok. I will add such a test

\o/

@ordnungswidrig: Do you mind if my editor removed some trailing whitespace? https://github.com/jonase/liberator/commit/860bb0978f98a4a13faec1fa2495f0045962f032

I opened the PR: https://github.com/clojure-liberator/liberator/pull/234 Let me know if something is wrong/missing

that was quick!

Thank! I did some bikeshedding and can merge when you updated the pr.

Cool! Do you want squashed commits or can I just add the changes as new commits?

Yes, squashed, please for these minor changes.

New PR, with your suggested changes: https://github.com/clojure-liberator/liberator/pull/235

Fine! You could have force pushed to your existing branch. No need open a new PR.

Yeap, I should have done that.

@ordnungswidrig: Thanks for the merge and thanks for liberator!

:simple_smile: