Clojurians Log v2
Clojure programming
Channels
Apps
lsp
:clojure-lsp: Clojure implementation of the Language Server Protocol: https://clojure-lsp.io/
snoe 2020-01-17T15:50:51.001200Z
@ericdallo should be "fixed"; it added a flag to the macro-def to ignore the diagnostic.
ericdallo 2020-01-17T15:53:31.001300Z
Thank you very much! Just curious.. 😅 do you plan to add this arity feature support for schema.core on the future?
snoe 2020-01-17T15:59:09.001600Z
I do not, but a PR would be welcome
ericdallo 2020-01-17T17:54:22.001900Z
it looks like already has a PR! https://github.com/snoe/clojure-lsp/pull/106
snoe 2020-01-17T18:46:16.002300Z
@ericdallo oh, there ya go 🙂 would you be able to test out his branch for me?
ericdallo 2020-01-17T19:01:08.002500Z
I'm trying, but i can't generate a local binary to test it 😕
I tryed running the install_clojure_lsp script, but i think it just install the latest binary from github release, right?
ericdallo 2020-01-17T19:01:34.002700Z
@snoe How can I generate the binary local for his branch?
snoe 2020-01-17T19:18:40.003Z
running lein bin will create a binary at target/clojure_lsp
ericdallo 2020-01-17T19:19:23.003200Z
thanks!
ericdallo 2020-01-17T19:24:22.003400Z
It works very well!
snoe 2020-01-17T19:30:00.003800Z
Thanks. I have a couple points of feedback after reviewing the code before I want to merge.
snoe 2020-01-17T21:55:03.004100Z
The release for this is going out now