lsp

:clojure-lsp: Clojure implementation of the Language Server Protocol: https://clojure-lsp.io/
ericdallo 2020-06-01T13:15:19.015700Z

@snoe, I could not find a way to implement the support for my custom macro, could you help me, please?

snoe 2020-06-03T14:25:26.018200Z

it is confusing, alternatively it seems like kondo is rolling out support for custom macros, it might be time to switch to just use kondo's diagnostics.

ericdallo 2020-06-03T14:38:03.018400Z

yeah, this could be a really nice integration

ericdallo 2020-06-01T13:19:00.016100Z

This is our framework for tests and our company uses this as default now

ericdallo 2020-06-01T13:21:38.016300Z

you can find some examples https://github.com/nubank/state-flow#clojuretest-and-matcher-combinators

snoe 2020-06-01T14:03:56.016600Z

It looks like it's going to have to be a code change for something like that... you want each flow to be both treated as potential params if a vector, as well as being treated as bound-elements

ericdallo 2020-06-01T16:21:25.016800Z

yes, I think something with a :repeat true for bound-elements could help, right?

snoe 2020-06-01T16:23:29.017Z

right, but maybe a match type like bound-params or bound-element

snoe 2020-06-01T16:31:50.017200Z

... I wonder if [:declaration {:element :element :pred :map} {:element [{:element :bound-params :pred :vector} {:element :bound-element :pred :not-vector}] :repeat true}] would work. So bound-params would need to be added that brings the reduced bound-scope in like bound-element does. Then add the not-vector pred.

ericdallo 2020-06-01T17:02:01.017500Z

oh, I could test it if you want

snoe 2020-06-01T17:11:17.017700Z

well it's got those couple missing pieces but if you add them, it could be a good pr. I probably won't work on it myself, since my feelings with "weird" uncommon macros is that if someone wants support they'll need to add it.

ericdallo 2020-06-01T17:13:29.017900Z

goit it, I still feel confuse about clojure-lsp's parser, but I can try 🙂 thank you!

👍 1