Clojurians Log v2
Clojure programming
Channels
Apps
lsp
:clojure-lsp: Clojure implementation of the Language Server Protocol: https://clojure-lsp.io/
ericdallo 2020-06-20T20:06:42.021100Z
:reviewplease: https://github.com/snoe/clojure-lsp/pull/147
snoe 2020-06-20T21:40:30.022700Z
@ericdallo How's that look on one line with multiarity or a bunch of params?
ericdallo 2020-06-21T14:09:46.027Z
Hum.. I followed what other lsps like lsp-dart and lsp-java do, At least for emacs, the default is show the first line only and the most of users don't know that they can increase to show more lines and particularly they/me too prefer to keep showing only one line 😕
snoe 2020-06-21T17:27:31.029300Z
So here's how it looks like in nvim - I prefer this, but that's what preferences are for - add one for display signatures on single line in hover and we can both be happy.
snoe 2020-06-21T17:28:16.030Z
ericdallo 2020-06-21T17:28:52.030500Z
I see, in nvim behaves weird indeed
ericdallo 2020-06-21T17:29:21.030700Z
so do you think a config like we do on .config.edn should be a good idea?
snoe 2020-06-21T17:29:36.030900Z
yup
snoe 2020-06-21T17:30:27.031100Z
and I think the multi-arity on your branch is still not quite right - should all be on one line right?
ericdallo 2020-06-21T17:30:54.031300Z
yes
ericdallo 2020-06-21T17:31:48.031500Z
Like I do here: https://github.com/snoe/clojure-lsp/pull/147/files#diff-f8159cdbc0e017113c5c7e2a28b7ca93R103
snoe 2020-06-21T17:32:52.031700Z
ah sorry, missed that commit
ericdallo 2020-06-21T17:34:47.031900Z
😅
ericdallo 2020-06-22T00:50:18.033200Z
Added the option to opt-in to the arity on same line 🙂
ericdallo 2020-06-20T21:45:11.022800Z
Do you mean something like this:
ericdallo 2020-06-20T21:45:15.023Z
ericdallo 2020-06-20T21:45:32.023400Z
It looks ok
ericdallo 2020-06-20T21:46:07.023600Z
I think CIDER print like this too on hover
ericdallo 2020-06-20T21:46:55.023900Z
And for a huge arity:
ericdallo 2020-06-20T21:47:30.024400Z
WDYT @snoe?