Clojurians Log v2

@ericdallo I'm going to test this out some more tomorrow - want to make sure the lsp4j upgrade doesn't have side effects.

no problem! Thanks for the fast feedback 🙂

@snoe This was the PR that added the most features of 0.9 if you want to take a look: https://github.com/eclipse/lsp4j/pull/397 It helped me to know what to change

thanks

Hey @snoe thanks for the merge! Can we generate a new release?

hrm, thought i did...

The latest is from 4 days 😅

yeah, I think it's replacing it 😕

ok, fixed; released

Thank you!

Yes, doom-emacs user 🙂 Really cool indeed @dpsutton, What do you think about implementing that on https://github.com/emacs-lsp/lsp-mode/blob/master/lsp-clojure.el#L55-L128? Or we can check on lsp-clojure.el if lsp-clojure-hydra.el is available and auto require it to minimize user configuration :) PRs are very welcome on lsp-mode :)

i probably wouldn't want this in lsp-mode for two reasons: 1. i doubt they have or are interested in a dependency on hydra, and 2. it would be much easier to iterate on this at the speed of changes to lsp without having to get a change into lsp, then lsp-mode. Better to put it into a lib that you can approve PRs yourself and release without requiring lsp-mode approval

I understand your concerns but we already have hydra integration for DAP: https://github.com/emacs-lsp/dap-mode/blob/master/dap-hydra.el and a integration for LSP it would be good too 🙂 I can say that the changes on lsp-mode are pretty fast, we are following lsp spec faster than they can provide new features 😛 But if you don't want to implement that on lsp-mode , we can still check if lsp-clojure-hydra package is available then require it automatically 🙂

oh then i'm all for it!

if neither of those sound like blockers i'm absolutely game

and would make it easier for everyone using lsp-mode and clojure-lsp to have it right away

as an aside, are you a regular contributor or core contributor for lsp-mode?

i've seen your name pop up in the gitter a bit now

I'm one of the maintainers 🙂

Questions and suggestions are welcome on gitter channel

awesome! good to know