lsp

:clojure-lsp: Clojure implementation of the Language Server Protocol: https://clojure-lsp.io/
pez 2021-02-03T00:18:42.246700Z

transduuuuce it! 😃

1
anonimitoraf 2021-02-03T06:56:10.247Z

Lol sorry, I don't have anything to contribute. I don't know about the internals of clojure-lsp nor clj-kondo. Is it possible to summarize the problem?

pez 2021-02-03T07:54:18.247200Z

@raf clojure-lsp can sometimes (when indexing a new project) consume a lot of memory. We’d like to get that in control without sacrificing too much of the speed.

anonimitoraf 2021-02-03T07:55:36.247400Z

Right. And memory is consumed by clj-kondo needing stuff in memory for analysis? What do classpaths have to do with it?

borkdude 2021-02-03T10:39:28.252400Z

Can't wait to have find-references for keywords work. E.g. I want to have the cursor on :refer and then get a list of all occurrences. Should work now with current clj-kondo analysis

2
ericdallo 2021-02-04T16:04:02.316Z

@snoe I'm adding support for keywords, but I realized clj-kondo don't recognize :refer or :as in ns form as keywords

ericdallo 2021-02-04T16:04:14.316200Z

the rest seems to work pretty well

borkdude 2021-02-04T16:05:21.316400Z

oh yeah, actually I wasn't after :refer in ns, but :refer in normal functions, for sci interpreter code

borkdude 2021-02-04T16:05:38.316600Z

so that should work well

ericdallo 2021-02-04T16:06:00.316800Z

oh got it 😅

borkdude 2021-02-04T16:06:11.317Z

we can probably leave the ns form out for now, since it's not common that people want to find those keywords I think

ericdallo 2021-02-04T16:06:18.317200Z

agree

borkdude 2021-02-04T16:07:35.317400Z

Just configured lsp for another subproject in the same mono-repo which has a slightly different way of building the classpath. Winning!

1
ericdallo 2021-02-03T11:01:54.252600Z

Oh, I missed that on clj-kondo, I though it was not available yet l

ericdallo 2021-02-03T11:02:13.252800Z

Nice, I can work on it soon

pez 2021-02-03T11:06:01.253Z

Was missing the like mad just an hour ago here. Drooling now. 😃

ericdallo 2021-02-03T11:08:28.253200Z

I Imagine de keywords analysis should increase a lot the analysis size right @borkdude?

ericdallo 2021-02-03T11:08:47.253400Z

Did you test it how much increased? Just a little concerned about the performance

ericdallo 2021-02-03T11:09:32.253600Z

Also, is there any opt-in flag for that? I lost the PR/commit that added that

ericdallo 2021-02-03T15:25:36.255900Z

We added integration tests to clojure-lsp :clojure-lsp: CI using babashka :babashka:🎉 (Ignore the next release, since I need to test the Github Actions running during graalvm build 😅)

4
❤️ 1
snoe 2021-02-03T17:26:13.260900Z

I mentioned in the lsp issue. raised, it's commented out in the analysis/README.md in kondo. I think to turn it on you pass :analysis {:keywords true}

👍 1
ericdallo 2021-02-03T17:27:40.261200Z

thanks