Weird, I remember this used to work for re-frame :thinking-face:
Yeah @nicdaoraf we lost that after clj-kondo integration, we are re adding it again 🙂
Ah right. Thanks! 😍 Curious though, why was it lost?
We had a huge refactor on clojure-lsp base here: https://github.com/clojure-lsp/clojure-lsp/pull/261
it improved almost everything and we decided to let this feature out of the PR until done on kondo side
Ah ok, understandable. Thanks for all the work btw. I'll check out Issues and try to help out when I get time
In the latest lsp-mode for emacs, you can now include the definition in refs:
(defun find-refs ()
(interactive)
(lsp-find-references t))
Nice, I didn't notice that
Released :clojure-lsp: https://github.com/clojure-lsp/clojure-lsp/releases/tag/2021.02.05-03.05.34 which add support for keywords analysis 🎉
• Find definition of aliased keywords (`::foo/bar`)
• find all keyword references (showing all usages when :foo/bar
)
• Completion
• Rename
• Document highlight showing same usages
@borkdude if clj-kondo return a :def for reframe, it'd be possible to make find-definition work for that 🙂 For now find-references shows all references of that keyword
Seems to work!
yeah, I think we should just hack the :def into clj-kondo
please make an issue for it and I'll get it done
some time soon
Sure!
Linking it: https://github.com/clj-kondo/clj-kondo/issues/1159