lsp

:clojure-lsp: Clojure implementation of the Language Server Protocol: https://clojure-lsp.io/
anonimitoraf 2021-02-05T01:44:54.339700Z

Weird, I remember this used to work for re-frame :thinking-face:

ericdallo 2021-02-05T01:55:05.339900Z

Yeah @nicdaoraf we lost that after clj-kondo integration, we are re adding it again 🙂

anonimitoraf 2021-02-05T02:05:50.340100Z

Ah right. Thanks! 😍 Curious though, why was it lost?

ericdallo 2021-02-05T02:15:10.340300Z

We had a huge refactor on clojure-lsp base here: https://github.com/clojure-lsp/clojure-lsp/pull/261

ericdallo 2021-02-05T02:15:43.340700Z

it improved almost everything and we decided to let this feature out of the PR until done on kondo side

anonimitoraf 2021-02-05T02:27:21.340900Z

Ah ok, understandable. Thanks for all the work btw. I'll check out Issues and try to help out when I get time

❤️ 2
borkdude 2021-02-05T08:40:45.341900Z

In the latest lsp-mode for emacs, you can now include the definition in refs:

(defun find-refs ()
  (interactive)
  (lsp-find-references t))

ericdallo 2021-02-05T12:04:49.342100Z

Nice, I didn't notice that

ericdallo 2021-02-05T13:15:39.344500Z

Released :clojure-lsp: https://github.com/clojure-lsp/clojure-lsp/releases/tag/2021.02.05-03.05.34 which add support for keywords analysis 🎉 • Find definition of aliased keywords (`::foo/bar`) • find all keyword references (showing all usages when :foo/bar) • Completion • Rename • Document highlight showing same usages

1
1
4
🙏 5
🎉 5
ericdallo 2021-02-05T13:17:00.344900Z

@borkdude if clj-kondo return a :def for reframe, it'd be possible to make find-definition work for that 🙂 For now find-references shows all references of that keyword

borkdude 2021-02-05T14:08:11.345100Z

Seems to work!

borkdude 2021-02-05T14:08:25.345500Z

yeah, I think we should just hack the :def into clj-kondo

borkdude 2021-02-05T14:08:47.345700Z

please make an issue for it and I'll get it done

🙏 1
borkdude 2021-02-05T14:08:51.345900Z

some time soon

ericdallo 2021-02-05T14:20:49.346100Z

Sure!

ericdallo 2021-02-05T22:06:52.347600Z

Linking it: https://github.com/clj-kondo/clj-kondo/issues/1159