Clojurians Log v2

Made a video about clojure-lsp (my initial experiences after using it for 1 week) https://youtu.be/WMnVv63ezFQ A little bit chaotic, apologies ;)

@ericdallo Unfortunately I had to remove a section about renaming since that didn't work at all :(

And you can also see how I have some problems with auto-complete... but I explained this yesterday.

But overall, good stuff ;)

Really good video @borkdude, thank you for that!

:)

Your completion issue is really odd indeed, I'll try to reproduce with a clean emacs later

@ericdallo You can try my entire emacs setup here: https://github.com/borkdude/prelude It even contains all elpa packages ;)

Hi folks, I often edit .cljc files with reader conditionals in the ns :require block:

(ns my-app.core
  (:require
    [my-app.foo :as foo]
    #?@(:cljs
      [[my-app.bar :as bar]])))

This seems to break the add-missing-libspec action. Should this work, or is it too much of a unique use-case to support?

It's indeed a bug @jkrasnay 😔 Please, open an issue with that minimal repro, clojure-lsp should know how to handle that IMO

Is there a way to configure the command to generate classpaths for each project?

What do you mean? What's your issue?

I have a clojurescript project that outputs cljs files (for source maps I think) to a directory nested under the resources directory of my project. Is there a way to make clojure-lsp ignore this directory? Sometimes when I try to navigate to a var definition, it jumps me to a file under this directory when the preferred file exists under my source directory.

I tried setting ignore-classpath-directories to true but that didn't seem to solve my problem

I have a project that needs aliases to generate the correct dev classpath. As in clojure -A:dev -Spath

@mynomoto This is what I have in .lsp/config.edn at work:

{:project-specs [{:project-path "deps.edn"
                  :classpath-cmd ["clojure" "-A:frontend:backend" "-Spath"]}]}

So what I would think that could work is a project specific project-specs.

Got it, you can configure a custom project-specs for that

yes, like that ☝️

Oh, this is great! Thank you @borkdude and @ericdallo.

Yeah, the ignore-classpath-directories is exactly for that, but I don't know exactly how it works, it's odd to me that it's a boolean, if true it'll ignore what folders? @snoe should that be a set of files/folders? otherwise, how that does work?

I'm currently attempting force lsp to start with a fresh late by deleting the sqlite.db file. Maybe it held onto some stuff when I set that ignore-classpath-directories thing

I'm trying to explore the https://github.com/furkan3ayraktar/clojure-polylith-realworld-example-app using lsp to navigate between the files. But the navigation works in several cases only after entering manually on the destination file. Should it work without that?

Yes, with the classpath scan when starting the project

check /tmp/clojure-lsp.*.out log when initializing the server

@mynomoto since it's a project with not default folders src test , you should configure it

with source-paths : https://clojure-lsp.github.io/clojure-lsp/settings/

or import the specific project instead of the root, like clojure-polylith-realworld-example-app/rest-api on the first time you open the project (lsp-mode should prompt for you to chosse the root, then you should choose the subproject if you wanna try this way)

So, those are on the :dev alias under :extra-paths and they apear on the classpath generated using clojure -A:dev -Spath

I'm using coc, I think it doesn't work the same as lsp-mode.

but are they on source-paths?

No, they are not. Just to make it clear to me, it won't work with :extra-paths?

OK, will do

And it has to be on the top-level of deps.edn? I renamed the extra-paths to source-paths on the alias (as there is no top-level source-paths) and got the same result.

no, they are different things, extra-paths is something you tell clj what are the extra-paths for your classpath, but clojure-lsp doesn't know that (or is not smarter enough, not sure that would be possible or could be confusing), so you need to tell clojure-lsp what are the dirs that contains the clojrue code of your project, the default are src and test

the source-paths need to be specified on .lsp/config.edn not in any deps.edn 😅

thank you!

Oh, got it, thanks! Let me try that.

For most common clojure projects, the default is enough, since this project use a different folders arch, you need to specify that

Sorry for missing the file where :source-paths should go, now everything is working. Thank you! I wonder if the classpath information (that considers the :extra-path configuration on deps.edn) should not be enough for analysis since that is what clj-kondo uses. I'm sure there is a reason why this is necessary and I just don't know what it is. Thank you for your work on clojure-lsp, I think is an amazing project!

I am unsure if I've fixed it. I deleted the sqlite.db file, I ran lein clean on my project (which cleaned up the extra cljs files in resources). I'm not jumping into that directory anymore. We will see if it holds.

Nice! Yeah, that something to improve probably, but we need to take care to not mess with already working source-paths, but I agree that should be cool feature to have, for leon projects too checking the project.el Feel free to open a feature request issue :)

Has anyone had any luck using clojure-lsp with Instaparse? Instaparse appears to define may of its symbols via a macro: defclone. This appears to confuse clojure-lsp triggering unresolved-vars errors. I tried fixing this by adding instaparse.macros/defclone clojure.core/def under the :lint-as key in .clj-kondo/config.edn, but that didn’t work.

Hey, I don't know what is Instaparse, but I imagine it has a custom macro, right?

If so, the correct way to fix the macro lint error is to configure via clj-kondo indeed with :lint-as

The config you mention should work

@zane past here the exact config

You will probably need to re-crawl your sources after adding that config

{:lint-as {clojure.test.check.clojure-test/defspec clojure.core/def
           clojure.test.check.properties/for-all clojure.core/let
           instaparse.macros/defclone clojure.core/def
           metaprob.generative-functions/gen clojure.core/fn}}

I see. How do I trigger a re-crawl?

I tried just making a small edit and saving.

@zane rm -rf .lsp/sqlite* and then re-open the project

Let me try that.

@ericdallo Maybe the crawler should take into account a hash of the clj-kondo config for caching?

@borkdude That fixed it. Cheers!

:thumbsup:

I was thinking exactly that @borkdude, we could hash the clj-config used

@borkdude By the way, I’m giving clojure-lsp another go because of your recent video, so thanks for that as well. 👍:skin-tone-2: 🙂

🎉 :)

Created this to improve that behavior 🙂 https://github.com/clojure-lsp/clojure-lsp/issues/331

I’m experiencing something a bit strange with completion. In one of the files in my project completion isn’t available before a certain line, but is available after it. The only significant thing about the line in question is that it has a .cljc reader conditional on it. :thinking_face:

could you show a little repro?

Would it help to create a repro project?

Or do you want the code around the line in question?

A repro project would be perfect, could you open an issue linking that project?

Will do (if I’m successful at creating the repro project!).