lsp

:clojure-lsp: Clojure implementation of the Language Server Protocol: https://clojure-lsp.io/
vemv 2021-07-03T14:53:27.288200Z

As perhaps a documentation topic, https://github.com/clojure-lsp/clojure-lsp/ or its links don't immediately say whether cljs is supported

ericdallo 2021-07-03T14:54:26.288300Z

Good point, I think most of features work with cljs (maybe clean-ns not that much)

ericdallo 2021-07-03T14:54:49.288500Z

But agree it's a good idea add a comment about that somewhere

👍 1
vemv 2021-07-03T14:56:16.288800Z

> (maybe clean-ns not that much) oh interesting, I figured both targets would be on par (since a static approach is followed, so JVM clj doesn't enjoy any 'privilege'?)

ericdallo 2021-07-03T14:59:12.289Z

yeah, I don't code clojurescript usually, so it'd need to test but I think those cljs requires that require js directly could not work fine with clean-ns

ericdallo 2021-07-03T14:59:22.289200Z

otherwise, I think everything else works

👍 1
vemv 2021-07-03T15:01:22.289500Z

cljs is an interesting topic, could be easily a killer/distinctive feature for the project (I'd happily contribute but always have quite a lot on my OSS plate :/)

vemv 2021-07-03T15:02:00.289700Z

I mean if cljs was tested/CI'd it would feel a little more dependable for that use case

ericdallo 2021-07-03T15:02:03.289900Z

No problem, if you could provide an issue that'd be a great start 🙂 Then I can work on that when have the time

ericdallo 2021-07-03T15:02:42.290100Z

yes agree, there are tests for cljs/cljc files already, if you find anything else that cljs is quite different we can add more tests/fix it

🙌 1
borkdude 2021-07-03T15:08:08.290500Z

as for clj-kondo: cljs is an explicit goal, if something isn't working correctly there I consider it as a bug

borkdude 2021-07-03T15:08:23.290700Z

so from an analysis data perspective, I think you should be good

👌 2