luminus

Piotr 2021-01-04T08:54:25.078100Z

@guswill That is actually something I am noticing also.

Piotr 2021-01-05T12:47:50.080500Z

I will have a look as well. @yogthos call to your experience, what is just about average result? I suspect that in my case it may be my environment, but I will check again.

yogthos 2021-01-05T16:09:47.080700Z

so last I looked at this was when I added luminus here https://www.techempower.com/benchmarks/#section=data-r19&hw=ph&test=fortune&l=zik0zf-1r

yogthos 2021-01-05T16:10:10.081Z

but this one is pretty stripped down https://github.com/TechEmpower/FrameworkBenchmarks/tree/master/frameworks/Clojure/luminus

yogthos 2021-01-05T16:10:57.081200Z

but yeah I can help take a look as well, would be good to see what's causing the slowdown

yogthos 2021-01-17T02:02:58.000400Z

@piotr.kurnik @guswill sorry haven't had a chance to look at this yet, have either of you had a chance to play with this?

Piotr 2021-01-17T21:37:35.000600Z

@yogthos Unfortunately, new job… 😉

yogthos 2021-01-17T22:19:34.000800Z

Congrats :)

Piotr 2021-01-18T06:54:09.001Z

First job in Clj, thanks!

GusWill 2021-01-18T15:30:43.001200Z

I haven't either, unfortunately, still enjoying my vacations. Will take a look when I get back.

Piotr 2021-01-19T13:42:10.003500Z

Lucky you ;-)

Piotr 2021-01-04T08:55:44.078300Z

I haven’t invested time into this yet, but probably soon I will have to. Can you share the template config you have used?

Piotr 2021-01-04T09:30:44.078500Z

@yogthos Can you think of anything that could cause that?

yogthos 2021-01-04T18:11:46.078700Z

my guess would be some of the middleware in the default template, one possibility could be format wrapping

yogthos 2021-01-04T18:12:37.078900Z

the drop @guswill is seeing seems pretty significant, I haven't benchmarked recently but it used to be within the same order of magnitude before

yogthos 2021-01-04T18:13:12.079100Z

so perhaps one of the middleware libraries that's currently in use is creating a performance hit now

yogthos 2021-01-04T18:15:06.079300Z

taking a look in wrap-base in the <app>.middleware namespace would be the place to start, and maybe just commenting out different pieces of middleware to see which one is the culprit

GusWill 2021-01-04T20:57:52.079500Z

Hey, sorry for dropping the bomb like this. On second thought I should've more more careful and shared reproducible benchmark results, but I was really strapped for time.

GusWill 2021-01-04T20:58:37.079700Z

I will try to find some time this week to get to the bottom of this.

GusWill 2021-01-04T21:01:22.079900Z

The backstory: we used luminus for an internal tool and, after we deployed to our cluster, a colleague complained about latency. I did a quick benchmark with ab and got something in the low tens. I then spent an afternoon debuggingthinking the deploy had somehow gone wrong.

GusWill 2021-01-04T21:02:07.080100Z

At the end of the day I decided to try the obvious: benchmark on my local machine. I got pretty much the same results.

GusWill 2021-01-04T21:03:37.080300Z

Anyways, I'm going to set aside time this week to benchmark different template combinations and report back.