Clojurians Log v2

Hi, what’s the rationale behind the lumo.repl/executeXXX functions being synchronous? and/or: is there a reason for eval and print being bolted together in executeXXX?

@cgrand you're refering to this part? https://github.com/anmonteiro/lumo/blob/master/src/cljs/snapshot/lumo/repl.cljs#L222-L223 I've been looking at this a tiny bit, when removeing this part, the repl just won't work.

no, not that

out of curiosity, do you get a stack overflow if you uncomment that?

no, not with dev, I remember just typeing command and press enter, and nothing happens and the promt disappears.

my main issue is there https://github.com/anmonteiro/lumo/blob/master/src/cljs/snapshot/lumo/repl.cljs#L1148

what’s the problem with that

we just get a value out of evaluation and it’s going straight to printing, I’d like to potentially suspend the loop here so it means introcuding a callback

can’t you use lumo.core/eval?

@anmonteiro sure I can. It all depends on what is your goal. Do you want to make lumo repls “upgradable” or do you want to require user to add some unrepl stuff to their classpath and specify a special :accept?

The later is already possible since you introduced :accept.

The former requires current lumo repl to be modified.