Clojurians Log v2

Hi With lumo 1.7.0

$ echo "{:foo :bar}" > resources/aha.edn

lumo -D aero:1.1.3 -c src:test -d

(require '[aero.core :refer [read-config]])
(read-config "resources/aha.edn")

fs is not defined
         aero$core$read_config_into_tag_wrapper (evalmachine.<anonymous>:829:386)
         Function.aero.core.read_config.cljs$core$IFn$_invoke$arity$2 (evalmachine.<anonymous>:860:61)
         aero$core$read_config (evalmachine.<anonymous>:844:30)
         Function.aero.core.read_config.cljs$core$IFn$_invoke$arity$1 (evalmachine.<anonymous>:865:30)
         aero$core$read_config (evalmachine.<anonymous>:848:30)
         (evalmachine.<anonymous>:1:23)
         Script.runInThisContext (vm.cljs:90:20)
         Object.runInThisContext (vm.cljs:297:38)
         (<http://Object.It|Object.It>)
         (Object.lumo.repl.caching_node_eval)

My guess is that something changed between Lumo 1.8.0 and the subsequent versions that doesn’t pick up fs node module.

This aero version 1.1.3 is the latest stable.

Any hints about what could be causing this would be much appreciated. I can will stick with Lumo 1.8.0 for time being. Thanks

When you open the latest lumo, what happens when you try to require the fs module?

Hey @futuro This is what happens: On Lumo 1.8

cljs.user=> (require 'fs)
cljs.user=> nil
cljs.user=> (fs.readFile "resources/aha.edn" (fn [_ data] (println data)))
nil
cljs.user=> #object[Buffer {:foo :bar}
]

On Lumo 1.10.1

cljs.user=> (require 'fs)
nil
cljs.user=> (fs.readFile "resources/aha.edn" (fn [_ data] (println data)))
fs is not defined
	 (evalmachine.<anonymous>:1:1)
	 Script.runInThisContext (vm.cljs:124:20)
	 Object.runInThisContext (vm.cljs:314:38)
	 (<http://Object.It|Object.It>)
	 (Object.lumo.repl.caching_node_eval)
	 (NO_SOURCE_FILE &lt;embedded&gt;:6029:9)
	 z (NO_SOURCE_FILE &lt;embedded&gt;:6030:22)
	 (NO_SOURCE_FILE &lt;embedded&gt;:6025:264)
	 Function.cljs.core.trampoline.cljs$core$IFn$_invoke$arity$1 (NO_SOURCE_FILE &lt;embedded&gt;:1927:142)
	 Function.cljs.core.trampoline.cljs$core$IFn$_invoke$arity$variadic (NO_SOURCE_FILE &lt;embedded&gt;:1927:280)

But then in the same REPL session:

cljs.user=> (require '[cljs.nodejs :as nodejs])
nil
cljs.user=> (def fs  (nodejs/require "fs"))
#'cljs.user/fs
cljs.user=> (fs.readFile "resources/aha.edn" (fn [err data] (println data)))
nil
cljs.user=> #object[Buffer {:foo :bar}
]

@dotemacs I’m puzzled — what made you think that . would work to access a namespace’s functions?

if you use (require 'fs) then use fs/readFile

fs.readFile is not a thing for namespaces

@dotemacs reading the aero source, they’re using the fs/readFileSync form, and the only difference is (:require ["fs" :as fs]).

Given that the function access looks right, my guess is that the latest lumo doesn’t like something about the require form.

I don’t know enough about cljs requires and how they work in lumo to hypothesize past that, but hopefully it’s enough to get you moving in the right direction.

The aero maintainers may know more if you open an issue

@anmonteiro ok, sorry, my bad. But why does fs.readFile work for Lumo 1.8 and not for Lumo 1.9+?

it might be an implementation detail

we’re not in control of what Node.js exposes in the scope

OK, thanks

@futuro I’ll open an issue for sure, thanks. But that require that you’ve shared above is in aero 1.1.3. Added here: https://github.com/juxt/aero/pull/59/files If I look in the code for aero 1.1.2, which used to work, for Lumo 1.7.0, it doesn’t work for Lumo 1.8.0. This particular code:

(require '[aero.core :refer [read-config]])
(read-config "resources/aha.edn")

lumo -D aero:1.1.2 -c src:test -d

Ah! I’d missed that you were on an older version.

Does your code work with aero 1.1.3?

If so, my guess is that older versions of lumo have the fs module available as part of environment, and newer versions don’t.

Which would explain the change is from aero 1.1.2->1.1.3

Regardless of the aero version used, the code works, up to Lumo 1.8. From Lumo 1.9+, the aero’s read-config throws an exception as per above.

How can I ensure that the fs module is part of the environment, so that aero continues to work correctly ?

I’ve raised an issue on aero’s repo, adding this here in case somebody else stumbles upon this issue: https://github.com/juxt/aero/issues/80

No clue about fixing aero, but I suspect the maintainers will know.