Clojurians Log v2
malli
Fixed a bunch of typos https://github.com/metosin/malli/pull/275
merged, thanks!
would like to make sci explicitly optional. either via a flag (non-breaking) or via explicit option (breaking, but for the better): https://github.com/metosin/malli/issues/276. Two days ago would have just done the latter, but now malli is released and goal has been not to break things. What do you think? save the breaking change for 1.0.0? just do it? something else?
@ikitommi Maybe sci could be one of many possible evaluators?
like clojure.core/eval is another one
and maybe the user should specify that
breaking would be ok I think
since the project is explicitly alpha
yes, the option1 would allow that:
(require '[malli.sci :as ms])
(require '[malli.core :as m])
(def options
{:evaluator (ms/evaluator)
:registry (ms/default-registry)})
(def Schema (m/schema [:fn '(fn [x] (string? x))] options))
(m/validate Schema "kikka")
; => true.. would also remove need of :preloads etc, as you actually need to require the code to make it work.
I think that's reasonable as long as it's documented well
and keep a list of breaking changes in CHANGELOG.md
malli.sci would still require sci for you right. so then there's no need for preloads
also, currently you can swap the default registry using the JVM/clj-compiler options, but not the default options. if you want to enable sci globally, that should be changed to swap the default options. I did a spike on that, but had too much open issues to think that through. Now, it seems like it would have been a right call.
that would be big breaking change, but something that could be documented and migrated easily too.
maybe all roads lead for quick 1.0.0 š
thanks for you thoughts on this.
Hi! does anyone have any experience using malli to validate/define the re-frame app-db?
@love.lagerkvist Iām doing this for forms currently https://github.com/stevebuik/fork-malli-ideas
works great. have not moved the app-db level validations from spec to Malli yet but I certainly plan to do so