nrepl

https://github.com/nrepl/nrepl || https://nrepl.org
bozhidar 2018-11-19T08:33:23.143900Z

@pez Hmm, that’s odd. We didn’t really change anything on our end in this regard, so that’s likely a change that happened in lein.

bozhidar 2018-11-19T08:34:14.144600Z

Actually the plugin is what generates the proper :repl-options, so you don’t have to do this manually.

bozhidar 2018-11-19T08:37:22.145100Z

Yeah, something changed in master - https://github.com/technomancy/leiningen/commit/3e1459a2b22db6ed39ed6a4de0f2695d1d3ceeeb

bozhidar 2018-11-19T08:38:08.145500Z

But the warning is actually about the lein middleware, not nREPL’s middleware.

bozhidar 2018-11-19T08:38:28.146Z

(lein middleware is simply a plugin that only transforms the project map)

bozhidar 2018-11-19T08:38:53.146500Z

Not sure what we’re expected to do this here, but despite the working everything should work just fine.

pez 2018-11-19T11:02:43.148500Z

OK. Checking that I understand which plugin you are referring to. If I remove [cider/cider-nrepl "0.18.0"] from the above profile, then leiningen stops complaining. Now I'll go read the links you provided. 😃

pez 2018-11-19T11:06:40.149400Z

Alright, I can't make sense out of that patch. Anyway. I can ignore the warning, right?

pez 2018-11-19T11:12:14.151400Z

I want to track down where from 0.2.13 -> 0.4.5 I stopped being able to decode the messages. Which version is it that is ”the same” as 0.2.13 now again?

bozhidar 2018-11-19T11:38:38.151600Z

> Alright, I can’t make sense out of that patch. Anyway. I can ignore the warning, right?

bozhidar 2018-11-19T11:38:45.151800Z

> I want to track down where from 0.2.13 -> 0.4.5 I stopped being able to decode the messages. Which version is it that is “the same” as 0.2.13 now again?

bozhidar 2018-11-19T11:39:16.152500Z

Nothing with respect to message encoding/decoding has changed between 0.2.13 and 0.4.5.

bozhidar 2018-11-19T11:39:31.152900Z

What exactly is the problem you’re encountering?

pez 2018-11-19T13:25:35.158200Z

I am trying to figure out what exactly is the problem, but what happens is that lots of the decoding starts to fail and also my nrepl client goes into an infinite loop endlessly failing decoding. It doesn't necessarily have to do with the encoding of the new nrepl. The client in Calva is a bit too naive and probably very sensitive to the order in which responses come back. It is time to fix that, and maybe I should before investigating the problems it has with 0.4.5.

bozhidar 2018-11-19T17:50:20.158700Z

No idea. Seems you can really use that EDN transport (or maybe the transit ones).

bozhidar 2018-11-19T17:50:59.159400Z

At any rate - I’m 100% certain that the encoding logic hasn’t changed at all, so the problem is likely unrelated.

pez 2018-11-19T19:16:01.160400Z

It seems that what my nrepl client is failing to decode is a java stack trace.

pez 2018-11-19T19:35:25.162400Z

Found it. It was the figwheel-sidecar dependency that needed to be updated to 0.5.17.

pez 2018-11-19T19:42:06.163900Z

Now most things work, but the test ops fail with a stack trace starting with Exception in thread "nREPL-worker-2" java.lang.IllegalArgumentException: No implementation of method: :send of protocol: #'clojure.tools.nrepl.transport/Transport found for class: nrepl.transport.FnTransport

pez 2018-11-19T19:43:40.164Z