Clojurians Log v2

@cfleming It probably works on Java 6, but I have no idea. It became hard to test against 6 at some point and I decided it wasn’t worth it. I’m reasonably certain it should work well with 7.

@bozhidar Ok, I’ll probably fork and create a Java 6 version to bundle with Cursive then.

It certainly doesn’t using anything special introduced in Java 8. I just removed 6 and 7 from the build matrix and changed the compiler flag.

It’s interesting that no one had asked about Java 6 and 7 so far. I just assumed even enterprises had updated by now. 🙂 I do assume we’d be stuck on Java 8 forever, though.

What would be involved in supporting java 6 and 7?

the javac flag? or do we need a way to test?

It’s just a matter of tweaking :javac-options ["-target" "8" "-source" "8"] in project.clj.

I think it has been set to Java 8 for quite a while now, but I don’t remember how long exactly.

Someone has to test this to make sure it actually works, I removed those JDKs from the CI when they were removed by Travis. Plus the build matrix had become huge (and the tests on Travis were super slow) and it seemed pointless to test platforms which weren’t used much, anyways.

Just confirmed - Java 8 has been the compilation target pretty much since the beginning of the new nREPL. See https://github.com/nrepl/nrepl/commit/90db7f9b36a35fa9fff8691a1e121e284ab5fdf4

@cfleming What was the version of nREPL Cursive bundled before? I was under the impression you had switched to nrepl/nrepl a while ago.

I've been looking at testing with Java 1.6 and 1.7 on CircleCI

the tricky part is finding a suitable Docker image. CircleCi's ones are based on the official Clojure images, which are, in turn, based on the Docker official OpenJDK ones

There are OpenJDK java 7 (and of interest, 12 and 13-ea) images, but the Clojure, and thus CircleCI ones, don't follow

@bozhidar No, my switch was very recent. I’ve been talking about doing it for a while 🙂

Got it.

> There are OpenJDK java 7 (and of interest, 12 and 13-ea) images, but the Clojure, and thus CircleCI ones, don’t follow

I imagined as much. TravisCI removed JDK 6 and 7 a while ago. Seems most people have written them off at this point.

I’d be fine with updating the build target upstream as well. I went over the code and I don’t see anything requiring JDK > 6. It’d be nice if we managed to run the tests somehow to be on the safe side, though. 😄