off-topic

https://github.com/clojurians/community-development/blob/master/Code-of-Conduct.md Clojurians Slack Community Code of Conduct. Searchable message archives are at https://clojurians-log.clojureverse.org/
Gleb Posobin 2020-10-19T04:46:06.403500Z

Is anyone using AWS amplify console to deploy a CLJS SPA? The build script I have takes 3 minutes to build because it downloads all the packages anew on every build, which sucks, I haven't been able to figure out how to enable caching for them.

orestis 2020-10-19T08:50:20.405400Z

@posobin Not sure if it applies to Amplify, but we solved similar issues in Elastic Beanstalk by building via a Github Action, uploading to S3, then triggering the deploy via the already-built bundle in S3.

orestis 2020-10-19T08:51:24.405500Z

To clarify, EB doesn’t try to build your app for you (I guess it can do via CodeCommit etc) but confusingly the eb CLI script didn’t give you access to the entire EB API, whereas the aws CLI script allowed us to do this.

borkdude 2020-10-19T15:51:32.407100Z

I want to disable automatically closing issues when people write "closes #xyz" in a PR on Github. How do I do this?

2020-10-19T15:58:34.407300Z

you can’t (

🙁 1
jaihindhreddy 2020-10-19T16:19:03.407400Z

In the meanwhile, you could ask people not to use https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword in their pull requests, in CONTRIBUTING.md or equivalent.

borkdude 2020-10-19T16:22:13.407900Z

I guess I could add it here: https://github.com/borkdude/clj-kondo/blob/master/doc/dev.md#pr

dominicm 2020-10-19T19:47:21.409100Z

You just gotta release every commit. It's continuous deployment in this jungle. Deploy or be deployed.

dominicm 2020-10-19T19:52:00.411300Z

A "workaround" would be to add a dev branch in the middle @borkdude https://github.blog/2013-01-22-closing-issues-via-commit-messages/ but it's not possible to change the default pull request branch. Github flow I suppose captures this: http://scottchacon.com/2011/08/31/github-flow.html

2020-10-19T19:55:36.411900Z

and, of course, you shouldn't merge a PR that says "fixes #xyz" and doesn't actually do so

borkdude 2020-10-19T19:56:29.412500Z

I usually look at the code and tests but sometimes miss fixes/closes etc in the text

alexmiller 2020-10-19T20:02:07.414500Z

just use patches instead :)

dominicm 2020-10-19T20:04:24.415700Z

Use !Github 😄

borkdude 2020-10-19T20:19:57.416Z

Maybe I'll set up a custom JIRA install somewhere

souenzzo 2020-10-19T20:34:56.416300Z

There is also jira cloud. it almost "works", you just need switch accounts 3 times, in incognito mode and switch do "old style UI v2-next". It will occour every time that you open the website. but after this "setup" it will "work" (a bit slowly)