off-topic

https://github.com/clojurians/community-development/blob/master/Code-of-Conduct.md Clojurians Slack Community Code of Conduct. Searchable message archives are at https://clojurians-log.clojureverse.org/
2021-05-25T04:43:38.119800Z

http://REPL.it now use nix package manager to build REPL sandbox environments https://blog.replit.com/nix

πŸ‘ 1
Tony Acero 2021-05-25T12:58:07.121100Z

😎

2021-05-25T04:44:00.120400Z

(Clojure is among the very first demos there)

❀️ 1
πŸŽ‰ 2
pez 2021-05-25T15:22:36.123200Z

I’ve got this super weird PR on a repo of mine: https://github.com/PEZ/rn-rf-shadow/pull/21 Some http://snyk.io bot involved and someone I have no clue who it is filing the PR. Is it some new way to advertise your services to have bots roaming around Github and β€œfixing” things?

2021-05-25T15:26:40.124600Z

It looks like a personal GitHub account that created it, according to profile of the GitHub user id

2021-05-25T15:27:53.126800Z

Snyk is software to identify versions of dependencies with security issues, if I recall correctly. The user probably scanned your code using snyk, it reported some warnings or issues, and this person thought you might want to make these changes

p-himik 2021-05-25T15:28:41.127100Z

The project.clj change looks really strange though.

emil0r 2021-05-25T15:28:48.127200Z

https://snyk.io/ and https://github.com/snyk-bot

emil0r 2021-05-25T15:29:22.127600Z

Not sure who put your repo in their list

2021-05-25T15:29:48.128600Z

Which looks even more like a relatively new coder making the change to me, rather than a bot

alexmiller 2021-05-25T15:30:14.129Z

snyk will notify you if you are using a dep that leads to a known vulnerability

alexmiller 2021-05-25T15:30:27.129300Z

which may lead someone to make a pr to fix it

emil0r 2021-05-25T15:30:50.129400Z

Next step from bots reporting on vulnerabilities

emil0r 2021-05-25T15:34:48.129600Z

Sounds very plausible

pez 2021-05-25T15:42:45.129700Z

I guess it can be quite usable. But super weird to get a PR like that without context.

futuro 2021-05-25T15:48:14.129900Z

I would verify that the change to the package.json file does, indeed, result in the same package-lock.json file that's in the PR

futuro 2021-05-25T15:49:10.130100Z

It's trivial to update a library in your package file which changes the lock file, and then they put in a couple extra dependencies in the lockfile by hand, hoping you won't inspect it @pez

lassemaatta 2021-05-25T15:52:36.130300Z

that github user looks rather suspicious. The user has created lots of random PRs/comments to dozens if not hundreds of repos. I wouldn't be suprised if it was a bot or some machine learning thing submitting random stuff to github for some reason. Then again, there are a lot of interesting people online so you never know, perhaps there is no malicious intent behind this..

pez 2021-05-25T15:59:16.130500Z

I should bump a lot stuff in that repository. Not going to pull that PR though, whatever the intent. πŸ˜ƒ

gklijs 2021-05-25T20:10:36.133Z

Snyk might even suggest a pr fix in some cases I think.