Clojurians Log v2

Sure I'll see what I can do

@eelke If it's a huge pain, we can cut the release as is. Worth investigating, though.

Yeah I need just need one build with the kill button removed. That is why I made it a compiler option

I am not that familiar with om-next, so not sure how to best pass a run-time variable to clojurescript

But I can relate to your argument

Okay, let's see what we come up with then.

ok thanks 🙂

As an alternative you can point me in the right direction and have a go. Would it be something like a get request from the client to the server for some app-state value?

I'm not sure to be honest - front-end isn't my area.

One thing we could to do to mitigate the pain it to factor out that build profile into a top level def in the project.clj

@eelke yeah, the basic idea is that you’d want the server to hold the environment variable so that the client can query it for whether or not the kill button should be displayed/enabled. I can look at it by tomorrow as well.

Sounds good. If it ends up being a huge pain we can go with the original approach, but that idea sounds fine, too.

@niamu and ideally you would check it on the back end when they kill-job, to prevent client side hacks allowing you to kill jobs. It isn’t really written to protect against its users though.

yeah, I’m sure I can do all of that by tomorrow. Assuming no one else beats me to it.

The dashboard really could use a wash at some point. Our front-end-fu was as poor when we wrote it as it is now, ha.