parinfer

shaunlebron 2018-02-12T18:46:16.000283Z

added some early thoughts for trying parinfer in Bruce’s new readline library: https://github.com/bhauman/rebel-readline/issues/84

shaunlebron 2018-02-12T18:46:57.000168Z

parinfer-jvm will have to be updated

shaunlebron 2018-02-12T18:47:49.000675Z

which is cool, because Timothy’s parinfer-based code validator will need it too: https://github.com/timothypratley/parsnip

cfleming 2018-02-12T21:20:05.000512Z

The reaction to parinfer smart mode in Cursive can be fairly described as “rapturous”

shaunlebron 2018-02-12T21:21:10.000054Z

ha, wow

shaunlebron 2018-02-12T21:21:33.000112Z

you getting this feedback in the #cursive channel or elsewhere?

cfleming 2018-02-12T21:22:14.000091Z

A bit by email, some here (mostly DMs), some on Twitter

cfleming 2018-02-12T21:22:23.000488Z

But people really seem to like it.

cfleming 2018-02-12T21:23:12.000601Z

e.g. https://twitter.com/CmdrDats/status/963016990158983168

cfleming 2018-02-12T21:23:22.000048Z

And the more concise: https://twitter.com/solussd/status/961808691220615168

cfleming 2018-02-12T21:23:41.000372Z

https://twitter.com/swlkr/status/961761844800061440

cfleming 2018-02-12T21:23:46.000613Z

https://twitter.com/swlkr/status/961762034625884160

cfleming 2018-02-12T21:23:53.000341Z

etc etc

cfleming 2018-02-12T21:24:44.000357Z

@shaunlebron Did you get a chance to play around with the incorrect indentation marking? Any opinions on that?

shaunlebron 2018-02-12T21:39:01.000076Z

Nice feedback! I wonder how many are trying it out. What would make you comfortable deploying it on next release?

shaunlebron 2018-02-12T21:41:08.000065Z

Pulling up Cursive now to play with the markers. My only issue with it in theory is that wrong indentation anywhere in the file will prevent Parinfer from working everywhere in the file

cfleming 2018-02-12T21:42:22.000247Z

Right, that’s the one thing I’d really like to fix. The user should be able to fix it themselves by just reformatting the file, of course.

cfleming 2018-02-12T21:42:52.000207Z

And I like that they have to do it manually - that means that their files don’t get reformatted just by looking at them.

cfleming 2018-02-12T21:47:20.000165Z

I’m going to investigate the “apply per top level form” change. If I can get that working then this will definitely become the next release right away. But honestly even without that this is still a vast improvement over what’s there anyway.

taylor 2018-02-12T21:53:24.000012Z

This is what turned some of my coworkers off from using Parinfer originally. They had a lot of poorly formatted/indented files and just opening them would rearrange and sometimes break things.

seancorfield 2018-02-12T21:54:29.000557Z

And what's the plan for atom-parinfer in terms of this new release? (I'm not even sure who is responsible for cutting releases of that)

cfleming 2018-02-12T21:54:40.000092Z

Yeah, this has annoyed me too. In a lot of my tests, I used to leave a dangling close paren at the end of my deftests, because it made it easier to copy assertions per line.

cfleming 2018-02-12T21:55:06.000638Z

Ironically of course, parinfer makes that more or less obsolete, but it’s still annoying to have a bunch of changes every time I look at a test file.

shaunlebron 2018-02-12T21:55:30.000396Z

@taylor: it’s one thing for it to annoy, but yeah, it should never break. that was a problem with a race condition in intellij I believe

cfleming 2018-02-12T21:55:54.000069Z

Right, breaking is a bug, the reformatting is just a bit annoying.

taylor 2018-02-12T21:56:18.000002Z

FWIW this was like over a year ago, not sure what has changed in main-line Cursive+Parinfer since

taylor 2018-02-12T21:56:28.000473Z

I’ve been happily using Cursive+Parinfer the whole time 🙂

cfleming 2018-02-12T21:56:28.000661Z

Essentially nothing, sadly.

shaunlebron 2018-02-12T21:58:08.000298Z

I’ll leave my feedback in #cursive

shaunlebron 2018-02-12T22:03:58.000369Z

@seancorfield i’m maintaining atom-parinfer for smart mode things, but chris is still the gatekeeper on releases

shaunlebron 2018-02-12T22:05:35.000541Z

feedback on atom-parinfer has been silent, except for your feedback sean. I still need to fix this: https://github.com/oakmac/atom-parinfer/issues/100

seancorfield 2018-02-12T22:15:47.000361Z

Okay. Thanks for the clarification on releases.