Clojurians Log v2
Clojure programming
Channels
Apps
pathom
:pathom: https://github.com/wilkerlucio/pathom/ & https://pathom3.wsscode.com & https://roamresearch.com/#/app/wsscode
Tyler Nisonoff 2020-08-04T18:22:53.396300Z
Hey all - beginner question I'm going through the book, and cannot get the parameters section to work I found https://github.com/wilkerlucio/pathom/blob/3242250e03f5f6b4c5faae1162e6358e9c9a36c1/docs-src/modules/ROOT/examples/com/wsscode/pathom/book/connect/parameters.cljs But I always get:
Execution error (ExceptionInfo) at com.wsscode.pathom.parser/expr->ast (parser.cljc:104).
Invalid expression 
souenzzo 2020-08-04T18:46:44.397200Z
@tylernisonoff
Where is (<!! (parser {} [(::instruments {:sort :instrument/brand})]))
Should be (<!! (parser {} '[(::instruments {:sort :instrument/brand})]))
souenzzo 2020-08-04T18:48:38.399Z
When you do [(:ident {:param 42})] on Clojure/REPL it actually evaluates to [nil], which is a invalid EQL
On Clojure/REPL, when you need "a EDN list", like (1 2 3) you need to quote it.
Tyler Nisonoff 2020-08-04T18:50:02.400300Z
ahhh got it, duh 🙂 Thank you! Think it's worth me submitting a PR to update this file in the examples?
souenzzo 2020-08-05T12:27:17.401400Z
added a small comment
Tyler Nisonoff 2020-08-05T12:51:02.401600Z
:face_palm: thanks for catching -- updated
Tyler Nisonoff 2020-08-05T12:55:44.401800Z
The "re-request review" button doesn't seem to do anything for me.. :thinking_face: :man-shrugging:
Tyler Nisonoff 2020-08-19T00:31:43.071800Z
@souenzzo when you can, mind reviewing the PR again?
souenzzo 2020-08-19T00:32:12.072Z
Just @wilkerlucio can merge
souenzzo 2020-08-04T18:54:00.400400Z
PR are welcome 🙂 cc @wilkerlucio
Tyler Nisonoff 2020-08-04T18:54:13.400600Z
cool will do!
Tyler Nisonoff 2020-08-04T20:56:36.401Z
https://github.com/wilkerlucio/pathom/pull/169 I included a note in the docs about this in the PR, but can remove that if it's unwarranted. (or happy to re-word it)