pathom

:pathom: https://github.com/wilkerlucio/pathom/ & https://pathom3.wsscode.com & https://roamresearch.com/#/app/wsscode
jimberlage 2020-09-11T19:35:48.021800Z

Is there a particular reason why defresolver/defmutation aren't wrapped with #?(:clj) at the moment? It prevents pathom from compiling under shadow-cljs, but I was wondering if there's a reason for doing it this way that I'm missing

souenzzo 2020-09-11T19:46:34.022300Z

@jimberlage you can use pathom both on server and client

jimberlage 2020-09-11T19:48:07.024400Z

I know - it shouldn't prevent functionality on the server. The other macros are wrapped in #?(:clj), which plays nice with clojurescript. It's only defresolver/defmutation that are unwrapped, which causes compiler errors

jimberlage 2020-09-11T19:50:43.025700Z

Here's an example of a macro in cljc that works well when compiling under shadow-cljs: https://github.com/wilkerlucio/pathom/blob/2c707bbcad45d37250a89332ae889865ab8498ca/src/com/wsscode/pathom/trace.cljc#L53

jimberlage 2020-09-11T19:51:29.026900Z

If the code were updated to do the same for the other macros, pathom would work under shadow-cljs no problem

wilkerlucio 2020-09-11T19:55:53.027900Z

@jimberlage hello, can you open a issue for it? or if you like to change and send a PR, welcome as well 🙏

jimberlage 2020-09-11T19:56:34.028500Z

I already have a PR open for it, if you want to check it out - https://github.com/wilkerlucio/pathom/pull/172

wilkerlucio 2020-09-12T13:53:53.030400Z

merged

1
wilkerlucio 2020-09-11T19:57:38.029900Z

:man-facepalming: my bad, checking it now

jimberlage 2020-09-11T19:57:43.030200Z

Really appreciate your work on pathom, btw!

🙂 1