Clojurians Log v2
Clojure programming
Channels
Apps
pathom
:pathom: https://github.com/wilkerlucio/pathom/ & https://pathom3.wsscode.com & https://roamresearch.com/#/app/wsscode
nivekuil 2020-11-13T06:03:20.303700Z
maybe a doc error: under wrap-mutate, I think`{:action out}` should be (:action out)? https://blog.wsscode.com/pathom/v2/pathom/2.2.0/plugins.html#_plugin_skeleton
wilkerlucio 2020-11-14T07:44:40.305500Z
no, that's correct, the mutation action fn need to be wrapped by the map having the :action key
nivekuil 2020-11-14T07:48:18.306900Z
huh.. I extract the :action key rather than wrapping the map and my plugin works.. same thing as https://github.com/wilkerlucio/pathom/blob/master/src/com/wsscode/pathom/profile.cljc#L46 ?
wilkerlucio 2020-11-14T07:56:03.307300Z
ah, sorry, you are right, that's just the condition to check if there is an action, so it should be (:action out) 👍
wilkerlucio 2020-11-14T07:56:17.307500Z
do you wanna send a PR with the fix?
nivekuil 2020-11-14T08:03:27.307700Z
sure, sent 🙂 https://github.com/wilkerlucio/pathom/compare/master...nivekuil:patch-1
nivekuil 2020-11-14T08:05:02.307900Z
aw, I've been typing so much fulcro/pathom that I instinctively typed in "env" instead of "out" when I wanted a three-letter variable. can't figure out how to amend the commit message through github
wilkerlucio 2020-11-14T08:08:04.308100Z
no worries, and site updated
2020-11-13T18:34:44.305200Z
@wilkerlucio have you release the project you talked about on clojurescript podcast? the one where you are grabbing data from local real estate sites