Clojurians Log v2
Clojure programming
Channels
Apps
pathom
:pathom: https://github.com/wilkerlucio/pathom/ & https://pathom3.wsscode.com & https://roamresearch.com/#/app/wsscode
dehli 2021-02-21T19:30:50.001100Z
Should throwing an exception from within a wrap-mutate plugin surface as a mutation error? It seems that the error is being swallowed somewhere.
wilkerlucio 2021-02-22T12:57:00.003Z
hello @dehli, I found the issue on the part that filters the output, that was swallowing the error, fixed on master
wilkerlucio 2021-02-22T12:57:12.003200Z
on top of that, a few things I like to suggest after looking at your code:
wilkerlucio 2021-02-22T12:57:17.003400Z
- No need to provide plugin-id when using defplugin
- p.a.eql alias should be used for async EQL, for sync it should be p.eql
dehli 2021-02-22T13:00:49.003800Z
Awesome, I’ll pull down latest! Also thanks for the suggestions! That’ll clean up the code!
wilkerlucio 2021-02-22T13:02:21.004Z
oh, since you were so fast
wilkerlucio 2021-02-22T13:02:27.004200Z
I acutally pushed a bug, but just fixed
wilkerlucio 2021-02-22T13:02:36.004400Z
c50d2e75dd084190c58c0e5a599c8e3f1a88d9ef should be fine
dehli 2021-02-22T13:03:18.004600Z
Perfect! Will use that SHA 🙂
dehli 2021-02-22T13:05:46.004800Z
Just validated that the fix worked as expected. Thanks for the quick fix!
wilkerlucio 2021-02-21T21:58:31.001800Z
ir should surface as a error value on the mutation response