seems I can't upgrade past https://github.com/wilkerlucio/pathom3/commit/4ddc0b765ceeecb0587cc7e031cb834bdc3c0444 or else queries that hit a few of my resolvers error with
com.wsscode.pathom3.connect.runner.async/run-node! async.cljc: 328
java.lang.IllegalArgumentException: No matching clause: :com.wsscode.pathom3.connect.planner/node-unknown
any breaking changes expected? I was on the commit right before that 7e61113f1818e63d9528e61344a79bca20db969c and that's also the last one that works.. weirdcan you try setting ::pcp/optimize-graph? false
on your env and see if you still see the issue?
and to confirm, you see that on master?
optimize-graph?
seems to have no effect. still just seems to loop through a few run-and-node!
calls before blowing up. yes, all this is done on master
a repro would be great, so can try to figure what's causing the issue
there was a breaking change regarding the ::pcr/wrap-resolve extension, do you have a plugin using that?
but may be a bug, seems an old change, can you make a repro case?
hmm.. there's an and node that references 11
but there is no node-id
11
so pcp/get-node returns nil for that node-id
oh, 7e6 is actually a different branch from 4ddc entirely.. github makes it look linear 😕
terrible hack I know, but I just set pcp/node-kind
to default to ::node-resolver
instead of ::node-unknown
and it works on master
I can't figure out a repro, happens even without any plugins
can you try setting ::pcp/optimize-graph? false
on your env and see if you still see the issue?
and to confirm, you see that on master?
What is the best way to handle exposing errors with the remove-stats-plugin
cominbed with the attribute-errors-plugin
? I tried following this: https://pathom3.wsscode.com/docs/built-in-plugins#remove-stats but when I add the remove-stats-plugin
before the attribute-errors-plugin
I lose all errors and will just return an empty map for a failing resolver. I alsno noted a deprecation message. I already turned off that transit exposes metadata so maybe I shouldn't care
Ah I fixed it by adding: :com.wsscode.pathom3.connect.runner/run-stats-omit? true
to the env
Ah then I still have the problem that when a resolver fails the parser returns an empty map
just taking a look at it now
not ideal, but one option is to just not encode meta on the transit as a workaround for now
and I deprecated the remove-stats, and renamed that omit flag
- `::pcr/run-stats-omit?` => `::pcr/omit-run-stats?`
- `::pcr/run-stats-omit-resolver-io?` => `::pcr/omit-run-stats-resolver-io?
`sorry the breakages, during when it still on time, planning to release an alpha this week
1hello everyone, for anyone using Pathom 3, there is a new option ::pcr/fail-fast? true
that you can use, this way exceptions get thrown up from resolvers/mutations immediatly
optimize-graph?
seems to have no effect. still just seems to loop through a few run-and-node!
calls before blowing up. yes, all this is done on master
Can we fail fast just mutations?
No worries at all it is expected, pathom3 is working very solidly already