pathom

:pathom: https://github.com/wilkerlucio/pathom/ & https://pathom3.wsscode.com & https://roamresearch.com/#/app/wsscode
nivekuil 2021-07-05T01:29:16.157Z

seems I can't upgrade past https://github.com/wilkerlucio/pathom3/commit/4ddc0b765ceeecb0587cc7e031cb834bdc3c0444 or else queries that hit a few of my resolvers error with

com.wsscode.pathom3.connect.runner.async/run-node!                 async.cljc:  328
java.lang.IllegalArgumentException: No matching clause: :com.wsscode.pathom3.connect.planner/node-unknown
any breaking changes expected? I was on the commit right before that 7e61113f1818e63d9528e61344a79bca20db969c and that's also the last one that works.. weird

wilkerlucio 2021-07-05T13:05:58.161100Z

can you try setting ::pcp/optimize-graph? false on your env and see if you still see the issue?

wilkerlucio 2021-07-05T13:10:00.161300Z

and to confirm, you see that on master?

nivekuil 2021-07-05T20:30:41.167500Z

optimize-graph? seems to have no effect. still just seems to loop through a few run-and-node! calls before blowing up. yes, all this is done on master

wilkerlucio 2021-07-06T05:48:50.168800Z

a repro would be great, so can try to figure what's causing the issue

wilkerlucio 2021-07-05T03:59:34.158500Z

there was a breaking change regarding the ::pcr/wrap-resolve extension, do you have a plugin using that?

wilkerlucio 2021-07-05T04:02:23.159400Z

but may be a bug, seems an old change, can you make a repro case?

nivekuil 2021-07-05T05:11:27.159600Z

hmm.. there's an and node that references 11 but there is no node-id 11

nivekuil 2021-07-05T05:12:33.159900Z

so pcp/get-node returns nil for that node-id

nivekuil 2021-07-05T05:19:45.160200Z

oh, 7e6 is actually a different branch from 4ddc entirely.. github makes it look linear 😕

nivekuil 2021-07-05T05:37:15.160400Z

terrible hack I know, but I just set pcp/node-kind to default to ::node-resolver instead of ::node-unknown and it works on master

nivekuil 2021-07-05T05:47:36.160700Z

I can't figure out a repro, happens even without any plugins

wilkerlucio 2021-07-05T13:05:58.161100Z

can you try setting ::pcp/optimize-graph? false on your env and see if you still see the issue?

wilkerlucio 2021-07-05T13:10:00.161300Z

and to confirm, you see that on master?

mitchelkuijpers 2021-07-05T13:26:40.164100Z

What is the best way to handle exposing errors with the remove-stats-plugin cominbed with the attribute-errors-plugin? I tried following this: https://pathom3.wsscode.com/docs/built-in-plugins#remove-stats but when I add the remove-stats-plugin before the attribute-errors-plugin I lose all errors and will just return an empty map for a failing resolver. I alsno noted a deprecation message. I already turned off that transit exposes metadata so maybe I shouldn't care

mitchelkuijpers 2021-07-05T14:17:01.164300Z

Ah I fixed it by adding: :com.wsscode.pathom3.connect.runner/run-stats-omit? true to the env

mitchelkuijpers 2021-07-05T14:17:59.164500Z

Ah then I still have the problem that when a resolver fails the parser returns an empty map

wilkerlucio 2021-07-05T14:41:46.164800Z

just taking a look at it now

wilkerlucio 2021-07-05T14:42:12.165Z

not ideal, but one option is to just not encode meta on the transit as a workaround for now

wilkerlucio 2021-07-05T14:44:55.165200Z

and I deprecated the remove-stats, and renamed that omit flag

wilkerlucio 2021-07-05T14:45:02.165400Z

- `::pcr/run-stats-omit?` => `::pcr/omit-run-stats?`
- `::pcr/run-stats-omit-resolver-io?` => `::pcr/omit-run-stats-resolver-io?
`

wilkerlucio 2021-07-05T14:45:25.165600Z

sorry the breakages, during when it still on time, planning to release an alpha this week

1
wilkerlucio 2021-07-05T14:53:36.167100Z

hello everyone, for anyone using Pathom 3, there is a new option ::pcr/fail-fast? true that you can use, this way exceptions get thrown up from resolvers/mutations immediatly

4👍3🙏
nivekuil 2021-07-05T20:30:41.167500Z

optimize-graph? seems to have no effect. still just seems to loop through a few run-and-node! calls before blowing up. yes, all this is done on master

souenzzo 2021-07-05T20:34:45.168Z

Can we fail fast just mutations?

mitchelkuijpers 2021-07-05T21:26:27.168300Z

No worries at all it is expected, pathom3 is working very solidly already