Clojurians Log v2

now that we’re trying to upgrade from 0.5.3 to 0.5.5 we’re running into https://github.com/pedestal/pedestal/pull/544/files#diff-c7e8051a2ca9de05fbfd6b4fc858ddc7. We’ve previously just enqueued map values as interceptors (which worked fine) but now the pre condition fails.

but looks like this was never intended. Would there be interest in accepting a change which makes enqueue also take values and converts them into an interceptor record?

if not maybe we should update the interceptors guide http://pedestal.io/reference/interceptors and change the code to produce interceptor records?

@mkvlr I encountered the same problem months ago and also asked in this channel

https://clojurians-log.clojureverse.org/pedestal/2018-09-20

https://clojurians-log.clojureverse.org/pedestal/2018-09-21

chain/enqueue is indeed intended to work only with Interceptor records

Yep, that is the intended behavior. We want to avoid interceptor xform and validation during chain execution.

because of performance considerations?

https://github.com/nextjournal/pedestal/commit/a5b69d376a30f8baefa1695789eaec7bf2144eed

seems pretty minimal to me…

is there some performance benchmarks I can run to see the impact?

You may want to vote for https://dev.clojure.org/jira/browse/CLJ-1473 to ensure that malformed pre/post conditions aren't silently skipped

@martinklepsch I want them to be skipped because they break my app 😼

but I see I want to upvote your comment re breaking change