Clojurians Log v2
pedestal
I don’t use async handlers today so I guess my code will look the same :)
For the life of mine I can’t figure out why upgrading lacinia-pedestal to 0.13.0 breaks GraphiQL for me. I’ve narrowed it down to com.walmartlabs.lacinia.pedestal/graphiql-ide-response which somehow generates connectionParams: --NO-MATCH--which of course the browser complains about — but even if I pass in ide-connection-params as an option I get the same result.
I’ve literally copy-pasted the function definition and when I call it locally, everything works as expected.
This is the version 0.13 function: https://github.com/walmartlabs/lacinia-pedestal/blob/34434816cbc3ac868b7522901a5f0e875c4916cb/src/com/walmartlabs/lacinia/pedestal.clj#L441
Huh. Of course the moment I try to attach a debugger everything works 😞
But not from a fresh VM. I’m not sure what’s going on.
Ah, wrong channel, was meant to go to #graphql — sorry
@orestis git bisect really helps in such cases. For a deps.edn based library and if you yourself use deps, you can point to a local copy of the library and run git bisect. But here I see they are using lein. I wonder if there is still a way to bisect.
Turns out that (as expected) it was a problem on my end (AOT compiled deps)
Having fixed my AOT problems and now actually using pedestal.log 0.5.8 I’ve found a breaking change which should be impacting everyone: https://github.com/pedestal/pedestal/issues/638#issuecomment-642714551
Seems like it’s only direct use of log/log that breaks it; log/info still works.
Good thing you figured it out. These types of bugs are always difficult.
@orestis sorry you ran into this issue. Creating an issue and will tackle tomorrow.
No worries, I figured it out and have a workaround :)