I learned a lot about lldb, javascriptcore, etc.
@mfikes: did you try out sh-async
before merging that PR?
I tried it after merging. Worked for me.
Nice!
On Linux I assume?
No. I tried it on OS X
@mfikes: do you think that sh-async
is enough to warrant another release of planck 2.0?
Sure… I can put out a beta 3
Sorry, alpha 3
cool
btw, make is failing locally for me.
any idea on that?
@johanatan: I’d suggest doing a script/clean at the top. My only guess is it needs to build the ClojureScript compiler afresh given that I’ve set it to build a specific commit hash.
👍:skin-tone-3:
That worked.
@mfikes: not sure if you're aware of this or if it is specific to me but:
Jonathans-MacBook-Pro:screencap jonathan$ brew install --HEAD planck
==> Cloning <https://github.com/mfikes/planck.git>
Updating /Users/jonathan/Library/Caches/Homebrew/planck--git
==> Checking out branch master
==> ./script/build-sandbox
Error: No such file or directory - build/Release/planck
Yeah… for now you’ll unfortunately need to do brew edit planck
and then add
depends_on “maven" => :build
(This is because I have Planck currently depending on building its own ClojureScript compiler.)i just ended up doing: build/script on a cloned copy of the src and copying the bin over to /usr/local/bin
@mfikes: i'm not a huge fan of code/information repetition. would you be opposed to merely surfacing the original docstring on sh-internal
from both sh
and sh-async
?
No… if there’s a way
Ok, I think there should be. I'll look into it.
(Also consider that 1.x still has the non-async version.)
So, this works:
cljs.user=> (def doc-string "doc string")
#'cljs.user/doc-string
cljs.user=> (def ^{:doc doc-string} a nil)
#'cljs.user/a
[how do you get planck to print out the docstring for a var tho? (just to verify that it actually did take effect)]
doc
Oh, dang it.
cljs.user=> (doc a)
re-find must match against a string.
cljs.core/re-find (cljs/core.cljs:9076:12)
planck.repl/undo-reader-conditional-whitespace-docstring (planck/repl.cljs:2373:38)
planck.repl/doc* (planck/repl.cljs:2736:3)
Looks like that might be a bug tho
i.e., ^{:doc "blah"} may not work either
Nope, this works:
cljs.user=> (def ^{:doc "blah"} c nil)
#'cljs.user/c
cljs.user=> (doc c)
-------------------------
cljs.user/c
blah
nil