@cap10morgan Landed planck.core/sleep
on master: https://github.com/mfikes/planck/commit/d9d055c5d03c9ad27b47ea9672cfd58f00f5b733
@cap10morgan Landed a surprisingly simple fix for the tail issue in this branch https://github.com/mfikes/planck/tree/issue-557 I'd like to test it out more thoroughly before merging it to master. But, feel free to check out that branch and give it a try.
oh... that is simple! nice. I'll will try that soon.
@cap10morgan Cool. If you don't have experience building Planck: https://github.com/mfikes/planck#building
ah, yes, that was going to be my next question. 🙂
I'd recommend FAST_BUILD=1 script/build
, otherwise the Closure optimization phase takes quite a while (half an hour)
With FAST_BUILD
, you can build it in a few minutes
great, thanks
I'm using fish shell on macOS 10.13.1, and got this on that branch:
$ env FAST_BUILD=1 script/build
Fetching Google Closure compiler...
Cleaning up Google Closure compiler archive...
### Building planck-cljs
Build Failed.
That smells like a Java 9 issue, given the quick failure
Are you running 9?
I'm running 1.8.0_152
I do have libzip, icu4c, and pkg-config installed via homebrew
OK... I need to run, but I would suggest taking a look at the script to see if you can stop it from supressing whatever the root failure is, if that's what's going on.
xxd or whatever it is? from vim?
looks like lein is trying to connect to a local maven repo and failing
with messages like: Could not transfer artifact org.clojure:test.check:jar:0.10.0-alpha2 from/to central (<https://repo1.maven.org/maven2/>): Connect to [localhost/127.0.0.1] failed: Connection refused (Connection refused)
I remember seeing that message, it seems to have something to do with the latest leiningen and certificates / https stuff
@cap10morgan just for a laugh, try lein upgrade 2.7.1
then doing the build
it’s easy to revert that with lein upgrade
if it doesn’t help
gotta run, will dig in more later. thanks!
ok maybe I don't need to run. I tried setting LEIN_VERSION
in planck-cljs/script/lein
to 2.7.1
but got the same failures
oh - so it has its own lein and it uses that version number to decide what to bootstrap with?
apparently! this is the first time I've tried building it.
it does look like it downloaded and used 2.7.1 FWIW
@cap10morgan The Planck build uses its own copy of 2.8.1 https://github.com/mfikes/planck/commit/2243a8a4450c52fec440de5196f2327e281f7e75
But maybe there is some bad interaction with other versions of Lein on your system. Hrm.
my primary lein is also 2.8.1
installed via homebrew
I just temporarily told planck to use 2.7.1 to test noisesmith's theory
I also have lein 2.8.1 via homebrew locally as well
Maybe I'll just land this on master so it is possible to do brew install --HEAD planck
All the unit tests are passing; I suspect the change is fine.
OK, @cap10morgan that change is on master. So you can just use homebrew to install it via brew install --HEAD planck
OK cool