planck

Planck ClojureScript REPL
2019-07-25T16:55:25.001700Z

I'm having a travis failure for a test suite that works locally https://travis-ci.org/leonoel/missionary Does the dump at the end look familiar to someone ?

mfikes 2019-07-25T17:05:09.003500Z

@leonoel I think it might be possible to get Planck to crash in odd ways if it shuts down while there are threads processing things. (It shouldn't crash, of course, but I think I've seen this before.) So, my first hunch is that there might be a timer in your script that is firing but the script ends, and things derail. Does that sound like it might be a possibility?

mfikes 2019-07-25T17:06:42.004400Z

Oh, cool, I see your code is open source.

2019-07-25T17:06:45.004500Z

the test suite is full of timers

2019-07-25T17:07:48.004800Z

using cljs.test/async

mfikes 2019-07-25T17:14:56.006800Z

@leonoel FWIW, it is passing for me locally with lumo

$ clojure -Acljs-test -x lumo

Testing missionary.core-test

Ran 17 tests containing 0 assertions.
0 failures, 0 errors.
But when I run it locally with planck, it terminates prior to the tests completing.

mfikes 2019-07-25T17:15:04.007Z

I smell a Planck bug.

mfikes 2019-07-25T17:15:48.007500Z

(To run with lumo, use 3.7.0 of the test runner.)

2019-07-25T17:16:27.007700Z

good to know

mfikes 2019-07-25T17:17:06.008600Z

Sometimes it runs properly, but sometimes it just terminates

Mikes-iMac:missionary mfikes$ clojure -Acljs-test -x planck

Testing missionary.core-test

Ran 17 tests containing 0 assertions.
0 failures, 0 errors.
Mikes-iMac:missionary mfikes$ clojure -Acljs-test -x planck
Mikes-iMac:missionary mfikes$

mfikes 2019-07-25T17:17:32.009Z

Planck will specifically keep the process running if it knows there are outstanding timers.

mfikes 2019-07-25T17:17:47.009200Z

(Just like Node.)

2019-07-25T17:19:21.009700Z

OK I will try to investigate more. Thanks for your time

mfikes 2019-07-25T17:39:54.010400Z

@leonoel I can see that the code in Planck that blocks until timers is complete isn't actually blocking. Seeing if I can sort out what that bug might be.

👌 1
mfikes 2019-07-25T20:35:28.010800Z

@leonoel Fixed https://github.com/planck-repl/planck/issues/998

👍 1