@seancorfield I made a https://github.com/seancorfield/usermanager-example/pull/6and the new page looks like https://github.com/tengstrand/usermanager-example/tree/refactor-components.
I also fixed the problem with the aliases that showed up as ?1, ?2… (in the issue-66 branch) + updated the SHA in the poly alias.
Thanks. Will take a look after I’ve had a coffee and provide feedback!
Sounds good.
I’ll be interested in your feedback on the schema
suggestion in my comments.
I’m busy, will have a look later.
I have pushed my changes and commented the PR @seancorfield.
I need to update the picture also, because I added a component.
Hold off on that for now — the final version will still look a bit different but the PR is a very helpful guide and check-list at this point!
I think there’s a bug in how the test helper sets up the database and I think the & db-spec
argument should be & [db-spec]
since it’s a single optional argument, not an optional sequence of arguments.
But I have a slightly different approach in mind that will be easier to discuss if I go ahead and do that refactoring and then you can provide feedback on it once you see the code — the sub-interface suggestion I made in the PR.
Sure, make the changes you want, and then I can have a look at it, and yes, looks like I introduced a bug!
I have pushed my changes by the way, so feel free to start working on it.