polylith

https://polylith.gitbook.io/ and https://github.com/polyfy/polylith
tengstrand 2021-03-31T07:56:59.480700Z

I also fixed the problem with the aliases that showed up as ?1, ?2… (in the issue-66 branch) + updated the SHA in the poly alias.

seancorfield 2021-03-31T16:09:11.481800Z

Thanks. Will take a look after I’ve had a coffee and provide feedback!

tengstrand 2021-03-31T16:38:43.482400Z

Sounds good.

seancorfield 2021-03-31T16:58:03.482600Z

I’ll be interested in your feedback on the schema suggestion in my comments.

tengstrand 2021-03-31T17:09:05.483300Z

I’m busy, will have a look later.

1
tengstrand 2021-03-31T20:37:20.483600Z

I have pushed my changes and commented the PR @seancorfield.

tengstrand 2021-03-31T20:47:46.483800Z

I need to update the picture also, because I added a component.

seancorfield 2021-03-31T20:52:16.484Z

Hold off on that for now — the final version will still look a bit different but the PR is a very helpful guide and check-list at this point!

seancorfield 2021-03-31T20:54:04.484200Z

I think there’s a bug in how the test helper sets up the database and I think the & db-spec argument should be & [db-spec] since it’s a single optional argument, not an optional sequence of arguments.

seancorfield 2021-03-31T20:54:58.484400Z

But I have a slightly different approach in mind that will be easier to discuss if I go ahead and do that refactoring and then you can provide feedback on it once you see the code — the sub-interface suggestion I made in the PR.

tengstrand 2021-03-31T21:00:51.484600Z

Sure, make the changes you want, and then I can have a look at it, and yes, looks like I introduced a bug!

tengstrand 2021-03-31T21:01:28.484800Z

I have pushed my changes by the way, so feel free to start working on it.

1