re-frame

https://github.com/Day8/re-frame/blob/master/docs/README.md https://github.com/Day8/re-frame/blob/master/docs/External-Resources.md
2020-09-24T01:16:41.009700Z

Hi, what’s the best way to subscribe to a list? Should I register a subscription for the whole list and then map across the elements with my view function, or is there some other way to subscribe to individual elements of a list that varies in length? I’m quite new to re-frame but I’ve read the tutorials once

2020-09-24T17:56:58.002100Z

Ok thanks

reefersleep 2020-09-28T12:00:55.005800Z

Nice flower logo, @kimi.im!

2020-09-24T01:50:09.009800Z

you can subscribe to the element of the list with subscript/index of the element

2020-09-24T13:30:51.001Z

would it make sense for run-test-sync to install an fx for :dispatch-later that did an immediate dispatch?

Rohan Nicholls 2020-09-28T11:46:46.005200Z

I’ve run into exactly the same problem:

(cond....
(:toaster-bus/bus db)
  {:dispatch [:toaster-bus/remove curr-id]
   :dispatch-later [{:ms (+ transition-ms 30) ;; once remove is finished add new
        :dispatch [:toaster-bus/show message]}]}

Rohan Nicholls 2020-09-28T11:51:56.005400Z

Basically, it has to wait for animations to finish. What I expected to happen was that run-test-sync would: • dispatch the first item (remove) • which runs an animation to remove the toaster, • when that is finished, removes the message from the db. • Then the :dispatch-later above kicks in, and • adds the new message to the db, • then runs the animation to show the toaster. In my test, it looks like the :dispatch-later is not happening, as the message after dispatching the initial message is the same.

Rohan Nicholls 2020-09-28T11:57:14.005600Z

@dannyfreeman I tried your code, but it lead to this error:

re-frame: while handling [:toaster-bus/hide] , dispatch-sync was called for [:toaster-bus/remove-message] . You can't call dispatch-sync within an event handler.

Rohan Nicholls 2020-09-28T12:06:54.006Z

Maybe I should just be using the async stuff? I’ll have a look and see if that solves my problem.

lispers-anonymous 2020-09-28T13:18:31.006500Z

Yes calling rf/dispatch-sync is not allowed from reg-fx I found out. It might be worth digging into re-frame a little and just calling the function registered to the :dispatch fx directly in the test fixture code.

Rohan Nicholls 2020-09-28T13:50:38.006700Z

Oh, that is a good idea.

lispers-anonymous 2020-09-24T15:46:35.001300Z

You could write a test fixture to do that. Does run-test-sync not automatically take care of that?

lispers-anonymous 2020-09-24T16:03:12.001500Z

(defn dispatch-later-sync
  [f]
  (rf/reg-fx
   :dispatch-later
   (fn [value]
     (if (map? value)
       (rf/dispatch-sync (:dispatch value))
       (doseq [effect (remove nil? value)]
         (rf/dispatch-sync (:dispatch effect))))))
  (f))

(use-fixtures :once dispatch-later-sync)
Maybe something like this would work for you. Whether or not you should do it depends on your use case. If you have a test that hits some code using :dispatch-later and it fails because the test finishes before the dispatch, then it probably makes sense.

2020-09-24T17:56:58.002100Z

Ok thanks

2020-09-24T18:36:39.002300Z

It does not do it, I had to write it - I thought it would surprise people

2020-09-24T18:37:19.002500Z

If you put it in a test fixture it will override for all tests. If it's inside run-test-sync then it will be removed at the end of the block