Clojurians Log v2

wouldn't it make sense to make functional components the default since it's a major version, breaking change would only affect some specific use cases that can be worked around, and it wouldn't make sense to start a new project without functional components given how important hooks are now in the ecosystem?

Maybe. But there could be some cases I don't know about that don't work.

at Status we haven't updated reagent for a while it's just not necessary, still using "0.7.0" but we would update for the functional components, but having the compiler option being stateful is more annoying that potential breaking changes

I think I'll try updating the project this week to see if functional components are breaking anything, but for sure being able to use hooks without hacks is going to be nice

> wouldn’t it make sense to make functional components the default since it’s a major version I don’t necessarily agree with this point because up till now, the only option was class components and many aren’t aware of this distinction, so it would be good to have people knowingly opt-in. > only affect some specific use cases that can be worked around Can we confidently say this? > without functional components given how important hooks are now in the ecosystem I like functional components as much as the next person, but I don’t actually think hooks are as widely adopted in the React ecosystem as one would initially think. I would argue these are used among early adopters and well maintained projects, but for many large codebases hooks don’t provide enough of an incentive for them to switch.

All these points are assuming I understand the current suggestion which is we opt-in to functional components 😉

I'm not a big user of react hooks (maybe I should be? don't even know what I'm missing out on) but the biggest benefit to me would be updating the React and ReactDOM versions so they don't conflict for more modern React component libraries. Even the most recent Reagent I can't use current builds of Material-UI or antd v4

It adds a lot of value if you are doing daily React development. But doesnt add any value in cljs land

You can use hooks in Reagent, this article explains clearly https://juxt.pro/blog/posts/react-hooks-raw.html

Also this is a an snippet from one of my projects. It uses MUI v4 and makeStyles hook.

(ns app.navigation
  (:require
   [reagent.core :as r]
   ["@material-ui/core" :refer [List ListItem Button]]
   ["@material-ui/styles" :refer [makeStyles]]
   ["@material-ui/icons" :refer [ExpandMore ExpandLess BarChart] :rename {ExpandMore ExpandMoreIcon
                                                                          ExpandLess ExpandLessIcon}]))

;;
(defn custom-styles [^js/Mui.Theme theme]
  #js {:root   #js {:margin-bottom (.spacing theme 3)}})

(def with-custom-styles (makeStyles custom-styles))

(defn navigation-item
  [{:keys [title icon label]}]
  [:> ListItem
   [:> Button
    [:> icon]
    title
    (when label
      [:> label])]])

;;
(def nav-list
  [{:title "Home" :href "/" :icon BarChart}
   {:title "Dashboard" :href "/dashboard" :icon BarChart}
   {:title "Projects" :href "/projects" :icon BarChart}
   {:title "Calendar" :href "/calendar" :icon BarChart}
   {:title "Clients" :href "/clients" :icon BarChart}
   {:title "Template Manager" :href "/templates" :icon BarChart}])

(defn navigation
  []
  (let [styles (with-custom-styles)]
    (r/as-element
     [:div {:class [(.-root styles)]}
      [:> List
       (for [nav nav-list]
         ^{:key (:title nav)}
         [navigation-item nav])]])))