reitit

https://cljdoc.org/d/metosin/reitit/ https://github.com/metosin/reitit/
koura 2020-06-08T07:53:09.086300Z

is this outdated: https://github.com/metosin/reitit/issues/84? Just updated to 0.5.2 and seems like it already is using a new UI at least

ikitommi 2020-06-08T08:32:05.087700Z

@tommi.jalkanen Still valid issue. The swagger-ui 3.0 support both 2.0 & 3.0 spec. reitit is still on 2.0 spec.

👍 1
koura 2020-06-08T11:07:23.087900Z

good to know, I'm interested in helping to push it forward during the summer

ikitommi 2020-06-08T13:11:37.088100Z

great! added a comment into the issue: https://github.com/metosin/reitit/issues/84#issuecomment-640593439

koura 2020-06-08T13:23:57.088400Z

thanks for making it easier to get started :thumbsup:

firstclassfunc 2020-06-08T15:05:26.089800Z

Hello all I am using

(ring/ring-handler
    (ring/router
      [...
But I need to implement ring.middleware.cors . Not sure where I can add this middleware into :data :middleware.. Any help greatly appreciated

dharrigan 2020-06-08T15:14:48.090600Z

I believe reitit now exposes an :options mapping, so you can specify - per route - which options are supported.

firstclassfunc 2020-06-08T15:15:23.091Z

@dharrigan hmm ok will take a look

dharrigan 2020-06-08T15:15:29.091200Z

https://github.com/metosin/reitit/issues/143

dharrigan 2020-06-08T15:15:40.091500Z

<https://github.com/metosin/reitit/pull/148>

dharrigan 2020-06-08T15:16:15.091700Z

Here's another example <https://github.com/metosin/reitit/blob/7f7d6e22565362ac2b1c21a413865bab38438bac/perf-test/clj/reitit/cors_perf_test.clj>

firstclassfunc 2020-06-08T15:59:31.092300Z

So just noticing that the default options just returns 200

HTTP/1.1 200 OK
Allow: GET,OPTIONS
Content-Length: 0
Server: http-kit
Date: Mon, 08 Jun 2020 15:58:45 GMT

&lt;Response body is empty&gt;
This obviously is not enough with CORS