reitit

https://cljdoc.org/d/metosin/reitit/ https://github.com/metosin/reitit/
Ykä 2021-02-03T12:45:24.073800Z

Moro! Looks like some Metosin libs (such as Muuntaja and Ring-http-response) have older and thus conflicting dependencies with Reitit (such as jsonista and ring-core). Would it be ok to make a PR to Muuntaja and Ring-http-response with just a dependency update – or is this already in the making?

Ykä 2021-02-03T12:46:40.073900Z

Additionally commons-codec seems to be conflicting between Muuntaja and Reitit, but this is a transitive dependency in muuntaja via Cognitect’s transit-clj and transit-java, so the upgrade path is a bit longer there.

ikitommi 2021-02-03T12:46:53.074100Z

PRs most welcome

👍 1
Ykä 2021-02-03T13:22:24.074400Z

Great! Is it ok to assume that running tests with new dependencies is enough to check that they don’t break things? Most probably people are already running Muuntaja and Ring-http-response with newer dependencies when they are using Reitit in the same project.

Ykä 2021-02-03T13:45:18.074600Z

Looks like lein all is the way to run all tests. I’m using that.