rewrite-clj

https://github.com/clj-commons/rewrite-clj
lread 2019-06-12T00:36:13.177900Z

good points @sogaiu !

borkdude 2019-06-12T16:11:31.178500Z

I’d like to maintain a fork of rewrite-clj for clj-kondo, related to this issue: https://github.com/borkdude/clj-kondo/issues/254

borkdude 2019-06-12T16:12:12.179300Z

considering the radio silence of the maintainer, I think I’ll just go ahead, as I think waiting for his reply can take forever…

lread 2019-06-12T17:16:15.183400Z

I’ll have something eventually @borkdude but am still currently distracted by some cljs work

borkdude 2019-06-12T18:04:11.184600Z

@lee Oh, I’m not posting this to pressure you. I’m not sure if I will switch to an alternative version of rewrite-clj… I’ll probably strip out only the stuff I need and optimize it, less surprises

lread 2019-06-12T18:11:33.187400Z

I did not think you were pressuring @borkdude! If my version were available without current rewrite-clj bugs, you’d probably use it though, right?

borkdude 2019-06-12T18:12:12.188100Z

if the tests would pass and performance was equal or better, probably yeah!

lread 2019-06-12T18:12:46.188800Z

Oh the pressure! 😅

borkdude 2019-06-12T18:13:08.189300Z

although I’ll probably need features that are too specific for rewrite-clj, like stripping out whitespace at parse time, etc. so I’m not sure

borkdude 2019-06-12T18:13:32.189900Z

if anything, I’d like to contribute all my changes back to the (actively maintained) original if that was meaningful to anyone

lread 2019-06-12T18:13:48.190300Z

they will be most welcome

borkdude 2019-06-12T18:13:48.190400Z

if I would make a different thing I mean

borkdude 2019-06-12T18:14:32.190900Z

eastwood also inlines dependencies to avoid conflicts

lread 2019-06-12T18:15:56.192200Z

hmmm… that’s interesting… unrelated but I was trying to use figwheel main to run rewrite-clj cljs tests and had to exclude rebel readline because it itself uses rewrite-clj…

borkdude 2019-06-12T18:17:19.192500Z

right, that’s what I mean 😉

lread 2019-06-12T19:33:15.192700Z

🙂

lread 2019-06-12T19:33:37.193100Z

(in other words, you taught me something yet again)