good points @sogaiu !
I’d like to maintain a fork of rewrite-clj for clj-kondo, related to this issue: https://github.com/borkdude/clj-kondo/issues/254
considering the radio silence of the maintainer, I think I’ll just go ahead, as I think waiting for his reply can take forever…
I’ll have something eventually @borkdude but am still currently distracted by some cljs work
@lee Oh, I’m not posting this to pressure you. I’m not sure if I will switch to an alternative version of rewrite-clj… I’ll probably strip out only the stuff I need and optimize it, less surprises
I did not think you were pressuring @borkdude! If my version were available without current rewrite-clj bugs, you’d probably use it though, right?
if the tests would pass and performance was equal or better, probably yeah!
Oh the pressure! 😅
although I’ll probably need features that are too specific for rewrite-clj, like stripping out whitespace at parse time, etc. so I’m not sure
if anything, I’d like to contribute all my changes back to the (actively maintained) original if that was meaningful to anyone
they will be most welcome
if I would make a different thing I mean
eastwood also inlines dependencies to avoid conflicts
hmmm… that’s interesting… unrelated but I was trying to use figwheel main to run rewrite-clj cljs tests and had to exclude rebel readline because it itself uses rewrite-clj…
right, that’s what I mean 😉
🙂
(in other words, you taught me something yet again)