rewrite-clj

https://github.com/clj-commons/rewrite-clj
lucas 2020-02-14T10:20:12.005300Z

Hi there! We are using a plugin that depends on this library and we are getting two warnings about methods not being public. We saw that they're fixed in this pull request https://github.com/clj-commons/rewrite-cljs/commit/7cc528ce3837563749f175e3e6e2c71ae62f983a but it is not released yet. Does anybody know when 0.4.5 version will be released?

2020-02-14T10:21:50.005700Z

the person to ask is probably @lee 🙂

👍 1
borkdude 2020-02-14T10:27:39.007200Z

@lucas.sousa I'm already using https://github.com/lread/rewrite-cljc-playground for https://github.com/borkdude/carve Several people are using carve and so far I haven't heard a single complaint with rewriting, so although it's called playground, I think it's already quite usable. Maybe you can try that as an alternative

lucas 2020-02-14T10:41:29.009800Z

I appreciate the information but it isn't in our hands to use it or not because the responsible for this dependency is a third party plugin. So we can't do anything about it :white_frowning_face:.

borkdude 2020-02-14T10:43:12.010Z

ok

lread 2020-02-14T12:18:20.011600Z

Hi @lucas.sousa! Is the 3rd party plugin open source?

lucas 2020-02-14T12:51:51.012900Z

yes, it is re-frame-10x. It has a dependency on zprint library which in turn depends on rewrite-cljs.

lread 2020-02-14T12:54:54.014600Z

And the warnings are being emitted by cljs compilation?

lread 2020-02-14T12:56:36.016800Z

Reason I ask these questions are that I intend rewrite-cljc to be the successor of rewrite-cljs and an option to for folks to move forward from rewrite-clj.

lucas 2020-02-14T12:59:35.020900Z

Yes, emitted by cljs compilation.

lread 2020-02-14T13:00:12.021300Z

Although technically I am a committer on clj-commons/rewrite-cljs, I’m more interested in investing my time into rewrite-cljc (which is very limited now, but should become ample soon 🤞)

lucas 2020-02-14T13:01:10.022100Z

Oh I see. Thanks for the explanation.

lread 2020-02-14T13:04:33.025200Z

I expect folks currently using rewrite-cljs will, when I get an official release out, be happy to move to rewrite-cljc. I’ve tested rewrite-cljc against cljfmt, you’ve just given me the good idea to also test it against zprint.

lucas 2020-02-14T13:07:38.026100Z

Glad to hear that 😄!

lucas 2020-02-14T13:08:39.027300Z

I never used zprint directly but re-frame-10x is awesome.

lread 2020-02-14T13:10:47.028500Z

coolio! there are so many awesome libs and awesome people in the clojure community!